Fix FailedRequests_ConnectionClosedWhileReceivingHeaders_Recorded #89047
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #88868.
|
| using HttpResponseMessage response = await SendAsync(client, request); | ||
| }).WaitAsync(timeout); | ||
| // Getting a cancellation is also good if we are unable to detect the peer shutdown. | ||
| using CancellationTokenSource cts = new CancellationTokenSource(1000); |
There was a problem hiding this comment.
preferably, we should not use magic numbers. Can we find some known passing/failing constant? .
There was a problem hiding this comment.
We only have TestHelper.PassingTestTimeoutMilliseconds = 60sec. This is too much, if we don't receive an RST from the server, I want the cancellation to fire relatively quickly while still making sure MetricsHandler is reached in the handler chain. Changed it to 10sec. I wasn't able to find a constant with similar semantics.
| connection.Socket.Close(); | ||
| try | ||
| { | ||
| var connection = (LoopbackServer.Connection)await server.EstablishGenericConnectionAsync().WaitAsync(20_000); |
There was a problem hiding this comment.
This should be actually cancelled when the client request completes, changed the test.
Fixes #88868.