Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestGenericAddStaticField #89145

Conversation

mikelle-rogers
Copy link
Member

@mikelle-rogers mikelle-rogers commented Jul 18, 2023

In the case of the assert, update the way the field index and field desc are accessed.

Fixes #87574

@mikelle-rogers mikelle-rogers self-assigned this Jul 18, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 18, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

In the case of the assert, update the way the field index and field desc are accessed.

Author: mikelle-rogers
Assignees: mikelle-rogers
Labels:

area-Diagnostics-coreclr, needs-area-label

Milestone: -

src/coreclr/vm/memberload.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/memberload.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/memberload.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/memberload.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/memberload.cpp Outdated Show resolved Hide resolved
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 21, 2023
@mikelle-rogers mikelle-rogers merged commit 08a6e06 into dotnet:main Jul 21, 2023
145 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EnC] CoreCLR assertion in System.Reflection.Metadata.ApplyUpdateTest.TestGenericAddStaticField
2 participants