-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exe size for Mach-O files #89325
Conversation
The extra size appears to be the export list, which is zeroed but not removed when the file is stripped. Exes shouldn't have any exported symbols by default, but ld will include everything by default. We'll fix it up using an ld flag.
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThe extra size appears to be the export list, which is zeroed but not removed when the file is stripped. Exes shouldn't have any exported symbols by default, but ld will include everything by default. We'll fix it up using an ld flag. Fixes #86707
|
Thinking about how to test this, but haven't been able to find a good answer. The linkedit segment is smaller after this change, but the symbols listed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The build fails with: Looks like this option was added only very recently and it is not present in our current XCode version yet: llvm/llvm-project@272bf0f |
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
…e.targets Co-authored-by: Jan Kotas <jkotas@microsoft.com>
The extra size appears to be the export list, which is zeroed but not removed when the file is stripped. Exes shouldn't have any exported symbols by default, but ld will include everything by default. We'll fix it up using an ld flag.
Fixes #86707