Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] fix the compiling errors by GCC. #89753

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix the compiling errors by GCC.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 1, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 1, 2023
@ghost
Copy link

ghost commented Aug 1, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

Fix the compiling errors by GCC.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@jakobbotsch jakobbotsch merged commit 1aded3f into dotnet:main Aug 1, 2023
125 checks passed
@shushanhf shushanhf deleted the fix_gcc branch August 1, 2023 11:15
@MinxuanZ
Copy link
Contributor

MinxuanZ commented Aug 2, 2023

LA compile it by clang before?

@shushanhf
Copy link
Contributor Author

shushanhf commented Aug 2, 2023

LA compile it by clang before?

In fact, we had compiled it by clang and gcc and tested it ok, but we use clang by default.
We just push our local patch to upstream.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants