Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By value out fixes #89982

Merged
merged 31 commits into from
Aug 8, 2023
Merged

By value out fixes #89982

merged 31 commits into from
Aug 8, 2023

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented Aug 3, 2023 •
edited
Loading

Builds on #89822 and #89971

Fixes #89968
Fixes #87845
Fixes #89897
Fixes #89791
Fixes #89747

@jtschuster
Add CleanupIn and CleanupOut
bd4c73e
@jtschuster
Rename to CleanupCallerAllocated and CleanupCalleeAllocated
ad4f5d4
@jtschuster
Rename CleansUpInStage to ShouldCleanupInCurrentStage
ba4e7bc
@jtschuster
Add more info in stage description comment
a0f63df
@jtschuster
Add test types
b4bdfb7
@jtschuster
Merge branch 'main' of https://github.com/dotnet/runtime into CleanupOut
90495fe
@jtschuster
Enable tests
751632e
@jtschuster
Move cleanup stage filter method to CustomTypeMarshallingGenerator
c562670
@jtschuster
Make marshaller types specific to each scenario
51f0c54
@jtschuster
Expect System.Exception from ThrowForHR on non-windows
26283fe
@jtschuster
Merge branch 'main' of https://github.com/dotnet/runtime into CleanupOut
be1739f
@jtschuster
Merge branch 'main' of https://github.com/dotnet/runtime into MakeMar…
c3152e2 
…shallersSpecific
@jtschuster
Expect System.Exception from ThrowForHR on NativeAOT
584567c
@jtschuster
wip
028b573
@jtschuster
Merge branch 'MakeMarshallersSpecific' into CleanupOut
e070681
@jtschuster
Cleanup ContentsOut guarded
73369c1
@jtschuster
Merge branch 'main' of https://github.com/dotnet/runtime into Cleanup…
acdbee9 
…Contents
@jtschuster
Don't cleanup [Out] elements in unmanaged to managed stub
e6c251b
@jtschuster
Fix some ByValueOut Behavior
aba85f5
@ghost ghost assigned jtschuster Aug 3, 2023
@ghost
Copy link

ghost commented Aug 3, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Builds on #89822 and #89971

Fixes #89968
Fixes #87845

Author: jtschuster
Assignees: -
Labels:

area-System.Runtime.InteropServices
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 5, 2023
Open
@jtschuster jtschuster marked this pull request as ready for review August 7, 2023 15:56
jkoritzinsky
jkoritzinsky approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

@jtschuster jtschuster merged commit 191ec61 into dotnet:main Aug 8, 2023
112 of 114 checks passed
@build-analysis build-analysis bot mentioned this pull request Aug 8, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT

Assignees

@jtschuster jtschuster

Labels
area-System.Runtime.InteropServices
Projects
None yet
Milestone
No milestone
3 participants
@jtschuster @jkoritzinsky @AaronRobinsonMSFT