Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade our TFM to net9.0 #90880

Merged
merged 21 commits into from
Aug 31, 2023
Merged

Upgrade our TFM to net9.0 #90880

merged 21 commits into from
Aug 31, 2023

Conversation

jkoritzinsky
Copy link
Member

Upgrade the TFM in the repo to net9.0

Drop support for net6.0 and net7.0

Follow-up to #90558

@ghost ghost assigned jkoritzinsky Aug 21, 2023
@ghost
Copy link

ghost commented Aug 21, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Upgrade the TFM in the repo to net9.0

Drop support for net6.0 and net7.0

Follow-up to #90558

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure
Milestone: -

@jkoritzinsky jkoritzinsky mentioned this pull request Aug 21, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Aug 22, 2023
Closed
@MihaZupan MihaZupan mentioned this pull request Aug 23, 2023
Closed
@jkoritzinsky
Copy link
Member Author

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

@radical
Copy link
Member

radical commented Aug 23, 2023

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

Sure, I can take a look later today.

ViktorHofer
ViktorHofer reviewed Aug 24, 2023
View reviewed changes
src/mono/wasm/testassets/WasmBasicTestApp/WasmBasicTestApp.csproj Outdated
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk.WebAssembly">
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this project can't use $(NetCoreAppCurrent)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that.

ViktorHofer
ViktorHofer reviewed Aug 24, 2023
View reviewed changes
src/coreclr/tools/aot/ILCompiler.Reflection.ReadyToRun/ILCompiler.Reflection.ReadyToRun.csproj
Comment on lines +19 to +23
<!--
The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true.
We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here.
-->
<IsTrimmable>false</IsTrimmable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.

@radical
Copy link
Member

radical commented Aug 24, 2023

@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR.

Sure, I can take a look later today.

I'll have to dig in tomorrow.

@radical
Copy link
Member

radical commented Aug 25, 2023 •
edited
Loading

re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting tfm=net9.0. Additionally emsdk needs new packages, and then corresponding we would add packages in runtime. For now, we'll need some little hack to get this passing, but it won't strictly be testing "the right stuff".

I'm working on this in #91105 , so it doesn't disturb work on this PR.

ViktorHofer added a commit to dotnet/arcade that referenced this pull request Aug 25, 2023
@ViktorHofer
Remove test TFMs from PackageTesting
32452ce 
Follow-up on dotnet/runtime#90880

These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year.

Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
@ViktorHofer ViktorHofer mentioned this pull request Aug 25, 2023
Merged
1 task
@radical radical mentioned this pull request Aug 30, 2023
Closed
@radical
Disable non-wasm build tests
e070989 
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:

```
        [] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build -  in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
        [] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
@radical
Override runtime pack for multithread
41d7eb9
@build-analysis build-analysis bot mentioned this pull request Aug 31, 2023
Closed
This was referenced Aug 31, 2023
Open
Open
@jkoritzinsky jkoritzinsky marked this pull request as ready for review August 31, 2023 16:24
@jkoritzinsky
Copy link
Member Author

I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback?

@ViktorHofer
Copy link
Member

Yeah, I need to debug one of those new suppressions. They shouldn't show up like that.

@ViktorHofer
Copy link
Member

Actually, let's look at the baseline suppressions in a follow-up.

@ViktorHofer ViktorHofer merged commit 85fa924 into main Aug 31, 2023
183 of 187 checks passed
@ViktorHofer ViktorHofer deleted the net90tfm branch August 31, 2023 16:40
marek-safar
marek-safar reviewed Sep 1, 2023
View reviewed changes
src/installer/tests/Assets/TestUtils/TestProjects.props
@@ -5,7 +5,7 @@
-->

<PropertyGroup>
<NetCoreAppCurrent>net8.0</NetCoreAppCurrent>
<NetCoreAppCurrent>net9.0</NetCoreAppCurrent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to use NetCoreAppCurrentVersion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These projects don't import the repo infrastructure.

@sbomer sbomer mentioned this pull request Sep 1, 2023
Closed
@ViktorHofer ViktorHofer added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Sep 12, 2023
@ViktorHofer
Copy link
Member

Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
@ericstj ericstj added this to the 8.0.0 milestone Oct 16, 2023
@jkoritzinsky jkoritzinsky modified the milestones: 8.0.0, 9.0.0 Oct 16, 2023
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@kasperk81 kasperk81 kasperk81 left review comments

@radical radical Awaiting requested review from radical

@ericstj ericstj Awaiting requested review from ericstj

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jkoritzinsky @radical @ViktorHofer @marek-safar @kasperk81 @ericstj @fanyang-mono