Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opportunistically use stack allocation for GC dynamic events #91001

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Opportunistically use stack allocation for GC dynamic events #91001

merged 2 commits into from
Sep 1, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Aug 23, 2023

No description provided.

@cshung cshung self-assigned this Aug 23, 2023
@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr
Milestone: -

@cshung @markples
Update src/coreclr/gc/gceventstatus.h
9a82347 
Co-authored-by: Mark Plesko <markples@microsoft.com>
markples
markples approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@markples markples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be excessive for this change, but this has me thinking about an abstraction for this pattern

Maoni0
Maoni0 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cshung cshung merged commit 528a5cf into dotnet:main Sep 1, 2023
109 checks passed
@cshung cshung deleted the public/stack-dynamic-events branch September 1, 2023 21:47
@EgorBo EgorBo mentioned this pull request Sep 7, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@markples markples markples approved these changes

Assignees

@cshung cshung

Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cshung @Maoni0 @markples