Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent restoring illink for native-binplace.proj #92289

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Prevent restoring illink for native-binplace.proj #92289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9080ebc
Prevent restoring illink for non-SDK project
sbomer Sep 19, 2023
f221691
Move setting to Directory.Build.props
sbomer Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move setting to Directory.Build.props
  • Loading branch information
@sbomer
sbomer committed Sep 19, 2023
commit f221691d7b21cb4352a2fb48eaf14f5a0c5af2f6
4 changes: 4 additions & 0 deletions src/libraries/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
we only enable it in specific projects. so to avoid duplicating this property in coreclr, we can first scope it to src/libraries.
This property needs to be declared before the ..\..\Directory.Build.props import. -->
<SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>

<!-- Prevent native-binplace.proj from being treated as a source project, to avoid importing illink targets
and thereby avoid hitting a static graph restore bug: https://github.com/dotnet/runtime/issues/92194 -->
<IsSourceProject Condition="'$(MSBuildProjectFile)' == 'native-binplace.proj'">false</IsSourceProject>
</PropertyGroup>

<Import Project="..\..\Directory.Build.props" />
Expand Down
1 change: 0 additions & 1 deletion src/libraries/native-binplace.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<BinPlaceRuntime>false</BinPlaceRuntime>
<BinPlaceNative>true</BinPlaceNative>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
<IsSourceProject>false</IsSourceProject>
</PropertyGroup>

<Import Sdk="Microsoft.NET.Sdk" Project="Sdk.targets" />
Expand Down