Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the native cross compilers on win-arm64 #92443

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Use the native cross compilers on win-arm64 #92443

merged 1 commit into from
Oct 28, 2023

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 21, 2023

No description provided.

@ghost ghost assigned lewing Sep 21, 2023
@steveisok
Copy link
Member

This is pending win-arm64 cross compiler support from @directhex.

@directhex
Copy link
Member

directhex commented Sep 22, 2023 via email

@lewing
Copy link
Member Author

lewing commented Sep 22, 2023

are the packages being built and published? should we turn this on in head and let people try out the builds? we could stand up a wbt win-arm64 lane for smoke tests if we have hosts

@steveisok
Copy link
Member

We will need to do an official build to validate. I do think there's value in having this in main.

@ghost ghost closed this Oct 22, 2023
@ghost
Copy link

ghost commented Oct 22, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@steveisok steveisok reopened this Oct 23, 2023
@lewing
Copy link
Member Author

lewing commented Oct 27, 2023 •
edited
Loading

kicked off an official build, we'll see how it goes

https://dev.azure.com/dnceng/internal/_build/results?buildId=2303077&view=results

@lewing
Copy link
Member Author

lewing commented Oct 27, 2023 •
edited
Loading

@steveisok looks green on the official build, should we merge and try it out?

@lewing lewing marked this pull request as ready for review October 27, 2023 23:58
@lewing lewing requested a review from radical as a code owner October 27, 2023 23:58
@steveisok
Copy link
Member

@steveisok looks green on the official build, should we merge and try it out?

YOLO!

@lewing lewing merged commit a153c19 into dotnet:main Oct 28, 2023
22 checks passed
@lewing lewing deleted the use-arm64-native-cross branch October 28, 2023 00:02
@akoeplinger
Copy link
Member

akoeplinger commented Oct 29, 2023 •
edited
Loading

FYI this was already done in #89651. The commit in main from this PR shows 0 changes 😄

liveans pushed a commit to liveans/dotnet-runtime that referenced this pull request Nov 9, 2023
@lewing @liveans
Use the native cross compilers on win-arm64 (dotnet#92443)
668b7af
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@lewing lewing

Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @steveisok @directhex @akoeplinger @radical