Enable SA1136: Enum values should be on separate lines #94098 #94100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
8 tasks
danmoseley
approved these changes
Oct 27, 2023
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsWrite.cs
Outdated
Show resolved
Hide resolved
|
Btw it's good to mention whether cleanup was done by hand or with a fixer, as the latter hopefully needs less careful eyeballing... |
This was referenced Oct 28, 2023
danmoseley
approved these changes
Oct 29, 2023
danmoseley
added
area-Meta
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFixes #94098, enabling another style rule. Includes a couple places where the rule does not make sense, but otherwise, this includes all the code clean-up as well. Style updates were done by hand.
|
|
BTW, we often put a comma on the last enum entry, to reduce diffs when adding to the enum. I didn't suggest that because it didn't seem that important. But maybe if there was a fixer for this, it should do that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94098, enabling another style rule.
Includes a couple places where the rule does not make sense, but otherwise, this includes all the code clean-up as well.
Style updates were done by hand.