we need to skip the SIP region in the last step of handling the alloc region #94249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
process_remaining_regions
, if we haven't gone through the while loop to handle the regions with pinned plugs, we can end up withcurrent_region
being an SIP region. then we mistakenly calldecide_on_demotion_pin_surv
which can change its planned generation. I'm filtering this out before we calldecide_on_demotion_pin_surv
because the pinned survival in an SIP region is always 0 so we wouldn't wantdecide_on_demotion_pin_surv
to treat it as "to be empty".thanks very much, @kevingosse, for reporting this!