Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Refactored GCToEEInterface and RedhawkGCInterface implementations into separate files. #95991

Merged
merged 23 commits into from
Dec 16, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
  • Loading branch information
VSadov and jkotas committed Dec 16, 2023
commit e5f4254d9d4ee269aed27185c993def61e1eb7b9
7 changes: 3 additions & 4 deletions src/coreclr/nativeaot/Runtime/GCHelpers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ GPTR_IMPL(Thread, g_pFinalizerThread);

bool RhInitializeFinalization();

// Perform any runtime-startup initialization needed by the GC, HandleTable or environmental code in gcrhenv.
// The boolean parameter should be true if a server GC is required and false for workstation. Returns true on
// success or false if a subsystem failed to initialize.
bool InitializeSubsystems()
// Perform any runtime-startup initialization needed by the GC, HandleTable or environmental code in gcenv.ee.
// Returns true on success or false if a subsystem failed to initialize.
bool InitializeGC()
{
// Initialize the special MethodTable used to mark free list entries in the GC heap.
g_FreeObjectEEType.InitializeAsGcFreeType();
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/Runtime/startup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ extern "C" volatile GSCookie __security_cookie = 0;
static RhConfig g_sRhConfig;
RhConfig* g_pRhConfig = &g_sRhConfig;

bool InitializeSubsystems();
bool InitializeGC();

static bool InitDLL(HANDLE hPalInstance)
{
Expand Down Expand Up @@ -150,7 +150,7 @@ static bool InitDLL(HANDLE hPalInstance)

STARTUP_TIMELINE_EVENT(NONGC_INIT_COMPLETE);

if (!InitializeSubsystems())
if (!InitializeGC())
return false;

STARTUP_TIMELINE_EVENT(GC_INIT_COMPLETE);
Expand Down
Loading