Remove the concept of packable fields from EEClass #96699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EEClass has long had a concept of packable rarely accessed fields - When we had NGEN we had logic to make these fields take very small amounts of space, but now that we no longer have NGEN, this code is not actually used in practice - The unpacked form of these fields used 4 bytes per field, even though many of them were logically 2 byte fields - The NumBoxed fields were just unnecessary, especially if we have a HasBoxedThreadStatics flag, which this change adds - Move the HasBoxed flags to the WFLAGS_LOW_ENUM Overall this saves 24 bytes per EEClass and moves all these fields onto a normal structure.
ghost
assigned 
AustinWise
reviewed
Jan 9, 2024
Co-authored-by: Austin Wise <AustinWise@gmail.com>
…ngen_thing_for_EEClass_fields
….com:davidwrighton/runtime into remove_special_ngen_thing_for_EEClass_fields
This was referenced Jan 11, 2024
elinor-fung
reviewed
Jan 16, 2024
| @@ -209,7 +190,7 @@ EEClass::CreateMinimalClass(LoaderHeap *pHeap, AllocMemTracker *pamTracker) | |||
| } | |||
| CONTRACTL_END; | |||
|
|
|||
| return new (pHeap, pamTracker) EEClass(sizeof(EEClass)); | |||
| return new (pHeap, pamTracker) EEClass(); | |||
There was a problem hiding this comment.
Does CreateMinimalClass still make sense as a separate helper now that 'minimal' is just normal?
There was a problem hiding this comment.
We still want to allocate using the LoaderHeap as that is what controls object lifetime. We have no mechanism in place to run delete and free memory for these piecemeal.
AaronRobinsonMSFT
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall this saves 24 bytes per EEClass and moves all these fields onto a normal structure.