-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][debugger] Fix debug lazy loaded assemblies when webcil is enabled #96800
Conversation
Tagging subscribers to this area: @thaystg Issue DetailsAs
And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from Fix #96736
|
Also, I think we should run the debugger-tests for .net8 with webcil enabled as this is the default behavior in a webassembly app. What do you think @lambdageek @radical |
I agree. I think we wanted to run both scenarios: webcil on and off, but never implemented it. |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAs
And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from Fixes #96736
|
/backport to release/8.0-staging |
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7482767578 |
As
image->raw_data
andimage->raw_data_len
are skipping thewebcil_section_adjustment
:runtime/src/mono/mono/metadata/webcil-loader.c
Line 148 in 4d34799
And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from
assembly_image->storage->raw_data
andassembly_image->storage->raw_data_len
Fixes #96736