Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][debugger] Fix debug lazy loaded assemblies when webcil is enabled #96800

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jan 10, 2024

As image->raw_data and image->raw_data_len are skipping the webcil_section_adjustment:

image->raw_data += webcil_section_adjustment;

And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from assembly_image->storage->raw_data and assembly_image->storage->raw_data_len

Fixes #96736

@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

As image->raw_data and image->raw_data_len are skipping the MonoWebCilHeader:

image->raw_data += webcil_section_adjustment;

And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from assembly_image->storage->raw_data and assembly_image->storage->raw_data_len

Fix #96736

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Jan 10, 2024

Also, I think we should run the debugger-tests for .net8 with webcil enabled as this is the default behavior in a webassembly app. What do you think @lambdageek @radical

@lambdageek
Copy link
Member

Also, I think we should run the debugger-tests for .net8 with webcil enabled as this is the default behavior in a webassembly app. What do you think @lambdageek @radical

I agree. I think we wanted to run both scenarios: webcil on and off, but never implemented it.

@radical radical added the arch-wasm WebAssembly architecture label Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As image->raw_data and image->raw_data_len are skipping the webcil_section_adjustment:

image->raw_data += webcil_section_adjustment;

And we need the raw image with the webcil headers for BrowserDebugProxy, I'm changing the assembly_loaded to send the full assembly from assembly_image->storage->raw_data and assembly_image->storage->raw_data_len

Fixes #96736

Author: thaystg
Assignees: thaystg
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@thaystg thaystg merged commit 31fa079 into dotnet:main Jan 11, 2024
23 of 25 checks passed
@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2024

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7482767578

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blazor] Unable to debug in lazy loaded assemblies
3 participants