Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve debug info for merged returns #96870

Merged

Conversation

BruceForstall
Copy link
Member

If converting a void GT_RETURN to a branch to a merged return block, keep it as a GT_NOP if it has debug info that should be preserved.

If converting a void GT_RETURN to a branch to a merged return
block, keep it as a GT_NOP if it has debug info that should
be preserved.
@ghost ghost assigned BruceForstall Jan 11, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

If converting a void GT_RETURN to a branch to a merged return block, keep it as a GT_NOP if it has debug info that should be preserved.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@mikelle-rogers mikelle-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes 89292

src/coreclr/jit/morph.cpp Show resolved Hide resolved
@mikelle-rogers mikelle-rogers linked an issue Jan 11, 2024 that may be closed by this pull request
@BruceForstall
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@BruceForstall BruceForstall merged commit 3f84acb into dotnet:main Jan 12, 2024
125 of 129 checks passed
@BruceForstall BruceForstall deleted the PreservedMergedReturnDebugInfo branch January 12, 2024 18:15
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
If converting a void GT_RETURN to a branch to a merged return
block, keep it as a GT_NOP if it has debug info that should
be preserved.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to break on callback from unmanaged thread
3 participants