Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding vectorized implementations of Exp to Vector64/128/256/512 #97114

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Adding vectorized implementations of Exp to Vector64/128/256/512 #97114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4dbad6
Adding vectorized implementations of Exp to Vector64/128/256/512
tannergooding Jan 17, 2024
7736a0d
Accelerate TensorPrimitives.Exp for double
tannergooding Jan 17, 2024
bb8dbd9
Ensure the right allowedVariance is used for the vectorized exp tests
tannergooding Jan 18, 2024
c81f0d7
Ensure V128/256/512 defers to the next smaller vector size by operati…
tannergooding Jan 18, 2024
a5909ef
Ensure the right allowedVariance amounts are used for the vectorized …
tannergooding Jan 18, 2024
7b04a92
Ensure we call Exp and that the methods are properly inlined
tannergooding Jan 18, 2024
398c78e
Skip the Exp test for Vector128/256/512 on Mono due to https://github…
tannergooding Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip the Exp test for Vector128/256/512 on Mono due to #97176
  • Loading branch information
@tannergooding
tannergooding committed Jan 18, 2024
commit 398c78eb528fc67596d35398c2cb9fdc530b3c99
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector128Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4689,6 +4689,7 @@ private static void TestGetOne<T>()

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpDouble), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpDoubleTest(double value, double expectedResult, double variance)
{
Vector128<double> actualResult = Vector128.Exp(Vector128.Create(value));
Expand All @@ -4697,6 +4698,7 @@ public void ExpDoubleTest(double value, double expectedResult, double variance)

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpSingle), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpSingleTest(float value, float expectedResult, float variance)
{
Vector128<float> actualResult = Vector128.Exp(Vector128.Create(value));
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector256Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5704,6 +5704,7 @@ private static void TestGetOne<T>()

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpDouble), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpDoubleTest(double value, double expectedResult, double variance)
{
Vector256<double> actualResult = Vector256.Exp(Vector256.Create(value));
Expand All @@ -5712,6 +5713,7 @@ public void ExpDoubleTest(double value, double expectedResult, double variance)

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpSingle), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpSingleTest(float value, float expectedResult, float variance)
{
Vector256<float> actualResult = Vector256.Exp(Vector256.Create(value));
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector512Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5136,6 +5136,7 @@ private static void TestIsNotSupported<T>()

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpDouble), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpDoubleTest(double value, double expectedResult, double variance)
{
Vector512<double> actualResult = Vector512.Exp(Vector512.Create(value));
Expand All @@ -5144,6 +5145,7 @@ public void ExpDoubleTest(double value, double expectedResult, double variance)

[Theory]
[MemberData(nameof(VectorTestMemberData.ExpSingle), MemberType = typeof(VectorTestMemberData))]
[SkipOnMono("https://github.com/dotnet/runtime/issues/97176")]
public void ExpSingleTest(float value, float expectedResult, float variance)
{
Vector512<float> actualResult = Vector512.Exp(Vector512.Create(value));
Expand Down
Loading