Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring XUnitLogChecker is included in libraries outerloop #97135

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Ensuring XUnitLogChecker is included in libraries outerloop #97135

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
009b309
DO NOT MERGE: Testing a forced crash
carlossanlop Jan 10, 2024
0c2fd59
To decide whether to include the XUnitLogChecker.csproj among the pro…
carlossanlop Feb 14, 2024
eeb2ea5
Revert "DO NOT MERGE: Testing a forced crash"
carlossanlop Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
To decide whether to include the XUnitLogChecker.csproj among the pro… 
…jects to build, check for TargetFrameworkIdentifier==.NETCoreApp instead of BuildTargetFramework==NetCoreAppCurrent.
  • Loading branch information
@carlossanlop
carlossanlop committed Feb 23, 2024
commit 0c2fd594d840ee56e86b65292a39fadfced81925
2 changes: 1 addition & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@
BuildInParallel="$(Samples_BuildInParallel)" />
</ItemGroup>

<ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(BuildTargetFramework)' == '$(NetCoreAppCurrent)' and '$(IsXUnitLogCheckerSupported)' == 'true'">
<ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and '$(IsXUnitLogCheckerSupported)' == 'true'">
<ProjectReference
Include="$(RepoRoot)src\tests\Common\XUnitLogChecker\XUnitLogChecker.csproj"
AdditionalProperties="%(AdditionalProperties);Configuration=Release;OutDir=$(XUnitLogCheckerLibrariesOutDir)" />
Expand Down
Loading