Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert HELPER_METHOD_FRAME in objectnative.cpp to QCall #97641

Merged
merged 17 commits into from
Feb 26, 2024
Merged

Convert HELPER_METHOD_FRAME in objectnative.cpp to QCall #97641

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d108638
Equals
huoyaoyuan Jan 29, 2024
5c827a5
GetHashCode
huoyaoyuan Jan 29, 2024
581bb9c
AllocateUninitializedClone
huoyaoyuan Jan 29, 2024
d3b9dcc
GetClass
huoyaoyuan Jan 29, 2024
62fa673
Use GetTypeFromHandleUnsafe instead to reduce code duplication
huoyaoyuan Jan 29, 2024
4cc5699
Merge branch 'main'
huoyaoyuan Feb 22, 2024
6a56bd6
Revert change of GetType
huoyaoyuan Feb 22, 2024
fb27520
Merge diff for AllocateUninitializedClone
huoyaoyuan Feb 22, 2024
8c45bd3
Compare object content in native code
huoyaoyuan Feb 23, 2024
84ff6d1
Fix return
huoyaoyuan Feb 23, 2024
46e9b7c
Revert changes around GetHashCode
huoyaoyuan Feb 23, 2024
1bac399
Remove unused functions
huoyaoyuan Feb 23, 2024
e041418
Do not compare padding in Equals
huoyaoyuan Feb 24, 2024
e7bbdd4
Fix assert touching OBJECTREF in preemptive mode
huoyaoyuan Feb 25, 2024
2d46bc0
Add test coverage for Equals
huoyaoyuan Feb 25, 2024
633f525
Fix FCall method binding
huoyaoyuan Feb 26, 2024
f2a0fc7
Add more test cases
huoyaoyuan Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix assert touching OBJECTREF in preemptive mode
  • Loading branch information
@huoyaoyuan
huoyaoyuan committed Feb 25, 2024
commit e7bbdd41716c9c97b9f7cb35754a27436635c7d8
4 changes: 2 additions & 2 deletions src/coreclr/classlibnative/bcltype/objectnative.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,12 @@ extern "C" void QCALLTYPE ObjectNative_AllocateUninitializedClone(QCall::ObjectH
{
QCALL_CONTRACT;

_ASSERTE(objHandle.Get() != NULL); // Should be handled at managed side

BEGIN_QCALL;

GCX_COOP();

OBJECTREF refClone = objHandle.Get();
_ASSERTE(refClone != NULL); // Should be handled at managed side
MethodTable* pMT = refClone->GetMethodTable();

// assert that String has overloaded the Clone() method
Expand Down