[wasm][debugger] Fix method overload resolution for arguments of type array in debugger's eval #97776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
EvaluateObjectByNonIntLocals
test we were trying to evaluate an expression like thiss[arr]
.We are trying to call get_Item method that expects an object as a parameter and this is not correct.
With the PR we are calling the get_Item that expects an array as a parameter .
Error on CI:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-97752-merge-dc23193aa5e44908bf/chrome-DebuggerTests.EvaluateOnCallFrameTests/1/console.e4d5ccf7.log?helixlogtype=result
Error message:
Unexpected runtime error/warning message detected: console.error: [MONO] * Assertion at /__w/1/s/src/mono/mono/component/debugger-agent.c:2018, condition
' not met`