Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] Update net8 mobile workload definitions #97824

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

lewing
Copy link
Member

@lewing lewing commented Feb 1, 2024

No description provided.

@ghost ghost assigned lewing Feb 1, 2024
@lewing lewing changed the title [workloadsRemove trailing commas [workloads] Remove trailing commas Feb 1, 2024
@lewing lewing requested a review from steveisok February 1, 2024 16:14
@lewing
Copy link
Member Author

lewing commented Feb 1, 2024

@steveisok it looks like we produce arm64 specific versions for several of those packs in 8.0.x so I've updated that as well

@akoeplinger
Copy link
Member

akoeplinger commented Feb 1, 2024

Yes that landed with #89961 but it looks like when the .net8 version of the manifest was created we probably duplicated the .net7 one instead of the .current so this got missed?

Would you mind diffing these two to make sure we're not missing anything else?

@lewing lewing changed the title [workloads] Remove trailing commas [workloads] Update net8 mobile workload definitions Feb 1, 2024
@lewing
Copy link
Member Author

lewing commented Feb 1, 2024

Yes that landed with #89961 but it looks like when the .net8 version of the manifest was created we probably duplicated the .net7 one instead of the .current so this got missed?

Yeah, and there were issues getting the baselines in that sort of stalled the review of the net8 manifests.

Would you mind diffing these two to make sure we're not missing anything else?

I've added the android changes as well. There appear to be new packs in the current manifest as well as the librarymode stuff that I'm not super clear what to do about in net8

@lewing lewing merged commit 2d7fe94 into dotnet:main Feb 2, 2024
22 checks passed
@lewing lewing deleted the remove-strays branch February 2, 2024 17:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants