Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: ARM64 SVE format encodings, SVE_BI_2A to SVE_HF_2A #98784

Merged
merged 3 commits into from
Feb 22, 2024
Merged

JIT: ARM64 SVE format encodings, SVE_BI_2A to SVE_HF_2A #98784

merged 3 commits into from
Feb 22, 2024

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Feb 22, 2024

Contributes to #94549

Adds formats:

  • SVE_BI_2A
  • SVE_HH_2A
  • SVE_BJ_2A
  • SVE_CB_2A
  • SVE_CG_2A
  • SVE_CH_2A
  • SVE_HF_2A

Note: Format SVE_HH_2A was not able to be decoded, but the format is simple enough that I'm quite confident in it.

Left: Capstone,
Right: Jit
image

@ghost ghost assigned TIHan Feb 22, 2024
@TIHan
Copy link
Contributor Author

TIHan commented Feb 22, 2024

@dotnet/jit-contrib @dotnet/arm64-contrib @kunalspathak @a74nh @amanasifkhalid this is ready.

@TIHan TIHan mentioned this pull request Feb 22, 2024
Closed
@TIHan
Copy link
Contributor Author

TIHan commented Feb 22, 2024

Just noticed that the JIT outputs dup, but the decoder shows it as mov. I'm assuming this is an alias?

@amanasifkhalid
Copy link
Member

Just noticed that the JIT outputs dup, but the decoder shows it as mov. I'm assuming this is an alias?

I believe it is; the docs say so.

amanasifkhalid
amanasifkhalid reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once the dups are displayed as mov. Thanks!

src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
@ryujit-bot
Copy link

Diff results for #98784

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.osx.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@a74nh
Copy link
Contributor

a74nh commented Feb 22, 2024

LGTM, will approve once the dups are displayed as mov. Thanks!

I agree with this :)

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 22, 2024
@TIHan
Copy link
Contributor Author

TIHan commented Feb 22, 2024

@amanasifkhalid this is ready again

amanasifkhalid
amanasifkhalid approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TIHan TIHan merged commit 5ce2674 into dotnet:main Feb 22, 2024
106 of 129 checks passed
@ryujit-bot
Copy link

Diff results for #98784

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Diffs are based on 2,554,585 contexts (1,019,526 MinOpts, 1,535,059 FullOpts).

MISSED contexts: 172 (0.01%)

Overall (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch 381,315,748 +0 0.00%
FullOpts (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch 165,778,652 +0 0.00%

Assembly diffs for linux/x64 ran on windows/x64

Diffs are based on 2,543,224 contexts (988,245 MinOpts, 1,554,979 FullOpts).

MISSED contexts: 177 (0.01%)

Overall (-3 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch 329,922,608 -3 +0.16%
FullOpts (-3 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch 147,120,622 -3 +0.16%

Assembly diffs for osx/arm64 ran on windows/x64

Diffs are based on 2,317,543 contexts (945,402 MinOpts, 1,372,141 FullOpts).

MISSED contexts: 170 (0.01%)

Overall (+12 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch 312,729,720 +12 +0.04%
FullOpts (+12 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch 111,327,984 +12 +0.04%

Assembly diffs for windows/arm64 ran on windows/x64

Diffs are based on 2,402,908 contexts (955,693 MinOpts, 1,447,215 FullOpts).

MISSED contexts: 174 (0.01%)

Overall (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch 328,693,680 +0 0.00%
FullOpts (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch 123,601,008 +0 0.00%

Details here

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.osx.arm64.checked.mch -0.01%

Details here

@ryujit-bot
Copy link

Diff results for #98784

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Diffs are based on 2,554,585 contexts (1,019,526 MinOpts, 1,535,059 FullOpts).

MISSED contexts: 172 (0.01%)

Overall (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch 381,315,748 +0 0.00%
FullOpts (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.arm64.Release.mch 165,778,652 +0 0.00%

Assembly diffs for linux/x64 ran on windows/x64

Diffs are based on 2,543,224 contexts (988,245 MinOpts, 1,554,979 FullOpts).

MISSED contexts: 177 (0.01%)

Overall (-3 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch 329,922,608 -3 +0.16%
FullOpts (-3 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.linux.x64.Release.mch 147,120,622 -3 +0.16%

Assembly diffs for osx/arm64 ran on windows/x64

Diffs are based on 2,317,543 contexts (945,402 MinOpts, 1,372,141 FullOpts).

MISSED contexts: 170 (0.01%)

Overall (+12 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch 312,729,720 +12 +0.04%
FullOpts (+12 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.osx.arm64.Release.mch 111,327,984 +12 +0.04%

Assembly diffs for windows/arm64 ran on windows/x64

Diffs are based on 2,402,908 contexts (955,693 MinOpts, 1,447,215 FullOpts).

MISSED contexts: 174 (0.01%)

Overall (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch 328,693,680 +0 0.00%
FullOpts (+0 bytes)
Collection Base size (bytes) Diff size (bytes) PerfScore in Diffs
libraries_tests.run.windows.arm64.Release.mch 123,601,008 +0 0.00%

Details here

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch -0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.osx.arm64.checked.mch -0.01%

Details here

@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Assignees

@TIHan TIHan

Labels
arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TIHan @amanasifkhalid @ryujit-bot @a74nh @kunalspathak