Stop overbuilding runtime-prereqs #98980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime-preqreqs is built twice with different global properties. Here's the global property diff: https://www.diffchecker.com/EN5CN7vm/
|
Tagging subscribers to this area: @hoyosjs Issue Detailsruntime-preqreqs is built twice with different global properties. Here's the global property diff: https://www.diffchecker.com/EN5CN7vm/
|
ViktorHofer
changed the title
jkoritzinsky
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime-preqreqs is built twice with different global properties. Here's the global property diff: https://www.diffchecker.com/EN5CN7vm/
I noticed that runtime.proj is invoked with different global properties than runtime-prereqs.proj and those global properties weren't removed.