[wasm][debugger] Shipping internal package for webcil #99380
Conversation
ghost
assigned 
|
@akoeplinger is this enough to ship the package internally as we do for |
|
Tagging subscribers to this area: @thaystg Issue DetailsShipping internally webcil package that will be consumed from an external repo.
|
src/mono/nuget/mono-packages.proj
Outdated
| @@ -9,7 +9,7 @@ | |||
| <ProjectReference Include="Microsoft.NET.Runtime.WebAssembly.Sdk\Microsoft.NET.Runtime.WebAssembly.Sdk.pkgproj" /> | |||
| <ProjectReference Include="..\wasm\templates\Microsoft.NET.Runtime.WebAssembly.Templates.csproj" /> | |||
| <ProjectReference Include="Microsoft.NET.Sdk.WebAssembly.Pack\Microsoft.NET.Sdk.WebAssembly.Pack.pkgproj" /> | |||
|
|
|||
| <ProjectReference Include="Microsoft.NET.WebAssembly.Webcil\Microsoft.NET.WebAssembly.Webcil.pkgproj" /> | |||
There was a problem hiding this comment.
This pkgproj doesn't exist, you'd need to create it
There was a problem hiding this comment.
Oh, I forgot to add the file!
There was a problem hiding this comment.
@thaystg if all you need is a nuget package then you don't need the .pkgproj (which is kinda deprecated), you can just set <IsPackable>true</IsPackable> in the .csproj.
| @@ -9,8 +9,7 @@ | |||
| <Serviceable>true</Serviceable> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <IsShipping>true</IsShipping> | |||
| <!-- this assembly should not produce a public package, rather it's meant to be shipped by the | |||
| WasmAppBuilder task and the BrowserDebugProxy --> | |||
| <!-- this assembly should produce a non-shipping package, because it will be used by BrowserDebugProxy --> | |||
There was a problem hiding this comment.
WasmAppBuilder still uses this though?
|
I'm not sure what the goal here is and what exactly you mean with "internal". The distinction we have is Shipping (i.e. to nuget.org) or Non-Shipping (to some dnceng-feeds) but both of these still mean the package is publicly available. |
The goal is to use it in another repo. It's okay to be in dnceng-feeds. Thanks for the explanation. |
Shipping internally webcil package that will be consumed from an external repo.