Skip to content

Commit

Permalink
Adjust comments based on PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
nguerrera committed Jan 25, 2018
1 parent b81d54d commit 4eae2d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/LockFileExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public static Dictionary<string, string> GetProjectFileDependencies(this LockFil

public static HashSet<string> GetProjectFileDependencySet(this LockFile lockFile)
{
// Get package name from e.g. Microsoft.VSSDK.BuildTools >= 15.0.25604-Preview4
string GetPackageNameFromDependency(string dependency)
{
int indexOfWhiteSpace = IndexOfWhiteSpace(dependency);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<!--
Update Reference items with NuGetPackageId metadata to set ExternallyResolved appropriately.
NetStandard.Library adds its assets in targets this way and not in the standard way that
would get ExternallyResolved set in ResolvedCompileFileDefinitions below.
would get ExternallyResolved set in ResolvePackageAssets.
-->
<Reference Condition="'%(Reference.NuGetPackageId)' != ''">
<ExternallyResolved>true</ExternallyResolved>
Expand Down

0 comments on commit 4eae2d7

Please sign in to comment.