dotnet-watch tests failing

[dsplaisted]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
841362	dotnet/sdk	Run TestBuild Tests	Log	#43015
841271	dotnet/sdk	Run FullFramework Tests	Log	#44008
840117	dotnet/sdk	Run TestBuild Tests	Log	#43988
839862	dotnet/sdk	Run TestBuild Tests	Log	#44106
839852	dotnet/sdk	Run TestBuild Tests	Log	#44104
839071	dotnet/sdk	Run TestBuild Tests	Log	#44084
838061	dotnet/sdk	Run TestBuild Tests	Log	#44050
837700	dotnet/sdk	Run TestBuild Tests	Log	#44008
835436	dotnet/sdk	Run TestBuild Tests	Log	#44019
832483	dotnet/sdk	Run TestBuild Tests	Log	#43978
832497	dotnet/sdk	Run TestBuild Tests	Log	#43979
831853	dotnet/sdk	Run TestBuild Tests	Log	#43239
831230	dotnet/sdk	Run TestBuild Tests	Log	#43955
2554989	dotnet-sdk	Run Tests in Helix	Log	#43133
828056	dotnet/sdk	Run Tests in Helix	Log	#43362
827675	dotnet/sdk	Run TestBuild Tests	Log	#43884
826254	dotnet/sdk	Run Tests in Helix	Log	#43849
826215	dotnet/sdk	Run FullFramework Tests	Log	#43555
826009	dotnet/sdk	Run Tests in Helix	Log	#43863
825469	dotnet/sdk	Run Tests in Helix	Log
822409	dotnet/sdk	Run TestBuild Tests	Log	#43787
821348	dotnet/sdk	Run FullFramework Tests	Log	#43776
820516	dotnet/sdk	Run TestBuild Tests	Log	#43760
819230	dotnet/sdk	Run TestBuild Tests	Log	#43724
818182	dotnet/sdk	Run TestBuild Tests	Log	#43514
817474	dotnet/sdk	Run TestBuild Tests	Log	#43672
816891	dotnet/sdk	Run FullFramework Tests	Log	#43541
2545144	dotnet-sdk	Run Tests in Helix and non Helix in parallel	Log	#43077
813521	dotnet/sdk	Run TestBuild Tests	Log	#43585
2542439	dotnet-sdk	Run Tests in Helix	Log	#43039
812555	dotnet/sdk	Run TestBuild Tests	Log	#43368

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
2	14	31

[marcpopMSFT]

@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-41616-merge-58511284b77c40778a/dotnet-watch.Tests.dll.1/1/console.418de7ca.log?helixlogtype=result

[tmat]

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

[marcpopMSFT]

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

[tmat]

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

[Forgind]

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

[Forgind]

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.