Expand osx-arm64 test coverage #44008
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
v-wuzhai
force-pushed
the
dev/Jason/Expand-osx-arm64-test-coverage
branch
from
e9eb935
to
5598c42
Compare
|
@MiYanni Is |
|
@MiYanni will be back on Friday. Looking at the logs, I see it ran the tests on osx.13.amd64.open so another change is needed somewhere in here to target the arm64 helix images. I can try to look tomorrow or we can wait for him or if you see where it should get updated, you can try that tonight. |
v-wuzhai
force-pushed
the
dev/Jason/Expand-osx-arm64-test-coverage
branch
from
4dfce23
to
deb027f
Compare
| /p:Rid=${{ parameters.runtimeIdentifier }} | ||
| ${{ parameters.osProperties }} | ||
| ${{ parameters.runtimeSourceProperties }} | ||
| /p:CustomHelixTargetQueue='osx.13.arm64.open'${{ parameters.helixTargetContainer }} |
There was a problem hiding this comment.
we can probably set the target queue upstream of this in a variable so we don't have to have the mostly duplicated if/else. miyanni can probably help with that.
There was a problem hiding this comment.
@MiYanni I'm not very familiar with this area, so could you please help me improve it?
|
It looks like the latest change got us to run the tests on arm64 successfully as far as i can tell. From the results, the most common failure is in R2R and illink tests when downlevel targeting (net5 and net3.1) A lot of these tests use EnvironmentInfo.GetCompatibleRid so I wonder if we should have some special logic there that returns an x64 rid when targeting <netN.0 and the default would be arm64. @agocke @elinor-fung Would ya'll want to keep around the downlevel targeting tests and is my proposal to change GetCompatibleRid reasonable or would you like to just get rid of the 3.1/5.0 targeting tests entirely? Alternatively, we could just modify the tests to return when run on arm64. |
|
cc @dotnet/illink for whether 3.1/5.0 targeting tests are still valuable If we do keep them, I'd suggest skipping downlevel on arm64 by switching the tests from |
…he minimum version to net6.0
|
We can get rid of 3/5 tests |
|
@v-wuzhai see agocke's comment above. Can you go through the tests that are failing on 3.1 and 5.0 in this PR and simply remove that coverage? Thanks. |
No description provided.