Use bundled implicit package versions #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dsplaisted
approved these changes
Mar 20, 2017
| <NetStandardImplicitPackageVersion>1.6.1</NetStandardImplicitPackageVersion> | ||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'"> | ||
| <!-- If targeting the same release that is bundled with the .NET Core SDK, use the bundled package version provided by Microsoft.NETCoreSdk.BundledVersions.props --> | ||
| <NETStandardImplicitPackageVersion Condition="'$(NETStandardImplicitPackageVersion)' =='' And '$(_TargetFrameworkVersionWithoutV)' == '$(NETStandardBundledReleaseVersion)'">$(NETStandardBundledPackageVersion)</NETStandardImplicitPackageVersion> |
There was a problem hiding this comment.
I'm not sure about the term "ReleaseVersion" in NETStandardBundledReleaseVersion. Should we call this NETStandardBundledTargetFrameworkVersion (and similar for the the .NET Core implicit reference)?
There was a problem hiding this comment.
Fixed. I moved Bundled to the front as well as I found it reads a little better.
livarcocc
approved these changes
Mar 21, 2017
nguerrera
force-pushed
the
version-props
branch
from
f82a28f
to
daf72b3
Compare
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…017.8 (dotnet#1012) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19517.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume props that will be provided with .NET Core SDK (via VS and core msbuild import hooks) to determine the implicit package versions.
The changes to actually generate and distribute this file in CLI are still pending. This can go in without them as it simply lights up on these versions being set and otherwise behaves as before.
I also fixed casing of NetStandard -> NETStandard for consistency (this is not breaking since msbuild property names are case insensitive).
@livarcocc @dsplaisted