Free metadata reader and assembly after reading metadata #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
approved these changes
Jul 26, 2017
rainersigwald
approved these changes
Jul 26, 2017
|
I applied the private you sent offline and can confirm that this fixes the scenario from NuGet/Home#5609. |
|
@dotnet-bot test Windows_NT_FullFramework Release
|
|
@livarcocc / @nguerrera I think folks want to take this for 2.0, anything we need to do to get that on the table? |
|
We need the same template here as other 2.0 pull requests and a linked VSO bug with the same ask mode template as the other bug fix we took to extensions (crypto facade change). I can't chase down links right now as I'm on my phone. I'll be in the office at ~10:30. |
|
This has been approved in shiproom. |
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…0200513.8 (dotnet#1456) Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers From Version 5.0.0-preview.6.20263.1 -> To Version 5.0.0-preview.6.20263.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes leak of assemblies where they weren't being closed until GC.
Fixes #1453
/cc @rainersigwald @livarcocc