Change xml formatting for store artifacts xml

[dasMulli]

Fixes most of https://github.com/dotnet/cli/issues/7010

Fixes #1490

cc @eerhardt @ramarag

[dasMulli]

Credit to @mikkelbu pointing out that line.

[guardrex]

@dasMulli What's the story on the casing of the package names? Is that one difficult/impossible to address?

[EDIT] I just realized those props are of the build. The list comes from the TargetOutputs.

[dasMulli]

I'm not sure what can be done about the package id casing. As far as I can tell it originates from the ResolvePublishAssemblies task which affects more code paths than just composing a store:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePublishAssemblies.cs

Line 86 in 40a0660

item.SetMetadata(MetadataKeys.PackageName, resolvedAssembly.Package.Id.ToString().ToLower());

[guardrex]

Excellent find. What about setting a new metadata item (for use later)?

item.SetMetadata(MetadataKeys.FriendlyPackageName, resolvedAssembly.Package.Id.ToString());

[guardrex]

Add one here: https://github.com/dotnet/sdk/blob/cd25d6bbfc2aac61cc790c511900427ac64fdaa8/src/Tasks/Common/src/MetadataKeys.cs

public const string FriendlyPackageName = "FriendlyPackageName";

[EDIT] btw--- What is stored in

sdk/src/Tasks/Common/src/MetadataKeys.cs

Line 9 in cd25d6b

public const string Name = "Name";

... that's not the friendly package name, is it?

[dasMulli]

Turns out the metadata in ResolvePublishAssemblies was only added for the store logic in the first place, the chained FilterResolvedFiles task then uses NuGet's PackageIdentity type which matches case-insensitive anyway.
I removed the ToLower() from ResolvePublishAssemblies . As long as any-cased package names in the file are valid, this should work 🤞

[guardrex]

🎉 Awesome @dasMulli!!!!

"I love it when a plan comes together!" - John "Hannibal" Smith (George Peppard), The A-Team, ©1983-87 Universal Television Stephen J. Cannell

[nguerrera]

@eerhardt Will removing this ToLower() break anything?

[eerhardt]

Package Ids are supposed to be case insensitive, so in theory it is fine to make this change. If it does break something, that something should be fixed to use a case insensitive comparison.

I did a quick look at where this is used, and the only place I found was it gets passed into FilterResolvedFiles, which then uses it to create a PackageIdentity, which does case insensitive comparisons. So this should be fine.

[guardrex]

Cool ... It's a UX issue if the files have lowercase package names. Some devs are bound to wonder: Do they always need to be lowercase in the artifact.xml file? This will fix that prob.

[nguerrera]

Waiting to get input from @eerhardt on casing.

[eerhardt]

Sorry for the delay in reviewing, I've been out of the office.

Looks good to me. Thanks for the contribution.