Provide shorter path to an unmanaged API. #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid DirectoryNotFoundException if CurrentDir+RelattivePath is longer than max path length.
|
Should fix #1544 |
|
/cc @dsplaisted |
ericstj
reviewed
Sep 8, 2017
| @@ -42,8 +43,9 @@ internal static bool GetFileDependsOnNETStandard(string filePath) | |||
| { | |||
| // on Windows use CLR's unmanaged metadata API. | |||
| // Create the metadata dispenser and open scope on the source file. | |||
| var filePathAbsolute = Path.GetFullPath(filePath); | |||
There was a problem hiding this comment.
@dsplaisted do you think we should do this here or in https://github.com/dotnet/sdk/blob/master/src/Tasks/Common/src/ItemUtilities.cs#L113?
Also, it may be better to first check IsPathRooted first for performance. The MSBuild code this is based off of does that: https://github.com/Microsoft/msbuild/blob/ab090d1255caa87e742cbdbc6d7fe904ecebd975/src/Tasks/AssemblyDependency/ReferenceTable.cs#L407-L414
|
Thanks for this contribution! |
nguerrera
approved these changes
Oct 7, 2017
|
@dotnet-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid DirectoryNotFoundException if CurrentDir+RelattivePath is longer than max path length.