Add Version metadata to SDK references #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dotnet/project-system#2248. When generating MSBuild items representing SDK references make sure to pass along the Version metadata. This way we can display it in Solution Explorer and the Properties window.
Update the existing unit test to verify that version numbers are copied over when we create new SDK reference items.
dsplaisted
approved these changes
Sep 12, 2017
|
Tagging @MattGertz for approval. |
|
@Pilchie actually. |
|
@MattGertz - this is an SDK fix, not project system. |
|
Ah, I missed seeing with repo I was looking at. :-) Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/project-system#2248.
When generating MSBuild items representing SDK references make sure to pass along the Version metadata. This way we can display it in Solution Explorer and the Properties window.