Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the OptIn test matrix for NuGet references #1578

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Adding the OptIn test matrix for NuGet references #1578

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6ddd72
Adding the OptIn test matrix for NuGet references - https://github.co…
johnbeisner Sep 11, 2017
de14e01
Resolving: https://github.com/dotnet/sdk/issues/1327
johnbeisner Sep 11, 2017
f72c267
Put the constructor back...
johnbeisner Sep 11, 2017
a452ea5
Backing out change for https://github.com/dotnet/sdk/issues/1327 due …
johnbeisner Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToVerifyNuGetReferenceCompat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,6 @@ public GivenThatWeWantToVerifyNuGetReferenceCompat(ITestOutputHelper log) : base
{
}

// https://github.com/dotnet/sdk/issues/1327
[CoreMSBuildOnlyTheory]
[InlineData("netstandard2.0", "OptIn", "net45 net451 net46 net461", true, true)]
[InlineData("netcoreapp2.0", "OptIn", "net45 net451 net46 net461", true, true)]
public void Nuget_reference_compat_core_only(
string referencerTarget,
string testDescription,
string rawDependencyTargets,
bool restoreSucceeds,
bool buildSucceeds)
{
Nuget_reference_compat(
referencerTarget,
testDescription,
rawDependencyTargets,
restoreSucceeds,
buildSucceeds);
}

[Theory]
[InlineData("net45", "Full", "netstandard1.0 netstandard1.1 net45", true, true)]
[InlineData("net451", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 net45 net451", true, true)]
Expand All @@ -59,6 +40,10 @@ public void Nuget_reference_compat_core_only(
[InlineData("netcoreapp1.0", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 netstandard1.3 netstandard1.4 netstandard1.5 netstandard1.6 netcoreapp1.0", true, true)]
[InlineData("netcoreapp1.1", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 netstandard1.3 netstandard1.4 netstandard1.5 netstandard1.6 netcoreapp1.0 netcoreapp1.1", true, true)]
[InlineData("netcoreapp2.0", "Full", "netstandard1.0 netstandard1.1 netstandard1.2 netstandard1.3 netstandard1.4 netstandard1.5 netstandard1.6 netstandard2.0 netcoreapp1.0 netcoreapp1.1 netcoreapp2.0", true, true)]

[InlineData("netstandard2.0", "OptIn", "net45 net451 net46 net461", true, true)]
[InlineData("netcoreapp2.0", "OptIn", "net45 net451 net46 net461", true, true)]

public void Nuget_reference_compat(string referencerTarget, string testDescription, string rawDependencyTargets,
bool restoreSucceeds, bool buildSucceeds)
{
Expand Down