Adding P2P test coverage for targeting common PCL profiles #1606
Conversation
johnbeisner
requested review from
nguerrera,
dsplaisted,
livarcocc and
wli3
| [InlineData("netstandard1.1", "Profile111", "v4.5", true, true)] | ||
| [InlineData("netstandard1.2", "Profile151", "v4.6", true, true)] | ||
| [InlineData("netstandard1.0", "Profile157", "v4.6", true, true)] | ||
| [InlineData("netstandard1.0", "Profile259", "v4.5", true, true)] |
There was a problem hiding this comment.
Not sure what the bools are for if they are always true,true.
We should probably also add cases that we expect to fail.
| @@ -0,0 +1,115 @@ | |||
| using Microsoft.NET.TestFramework; | |||
There was a problem hiding this comment.
Add copyright header matching other files.
| @@ -21,10 +21,12 @@ public class TestProject | |||
| public string RuntimeFrameworkVersion { get; set; } | |||
|
|
|||
| public string RuntimeIdentifier { get; set; } | |||
|
|
|||
There was a problem hiding this comment.
nit: unecessary whitespace diff
| } | ||
|
|
||
| // Skip running test if not running on Windows | ||
| // https://github.com/dotnet/sdk/issues/335 |
There was a problem hiding this comment.
I would expect these tests wouldn't work on .NET Core msbuild because the deployment doesn't carry the PCL targets.
There was a problem hiding this comment.
I see now that even core msbuild can build these projects in the test environment because we force a VS Dev command prompt which sets VSINSTALLDIR and core msbuild is "crossing the streams" into VS land to pick up these targets. Since we already require a VS command prompt for building/testing SDK (there's an error from build.cmd otherwise currently), I suppose this is OK.
Bump pinned SDK to 7.0.100-preview.4.22252.9
Addressing 1/2 for: #1065