Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take out workarounds which mark files from NuGet packages as executable #1670

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Take out workarounds which mark files from NuGet packages as executable #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.CrossGen.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,6 @@ Copyright (c) .NET Foundation. All rights reserved.

<Message Text="CrossgenCommandline: $(CrossgenCommandline)"/>

<!-- Workaround for https://github.com/NuGet/Home/issues/4424 -->
<Exec Command="chmod 755 $(CrossgenExe)" Condition="'$(OS)' != 'Windows_NT'"/>

<!--Optimization skip if the assembly is already present in the final output directory-->
<Exec
Command="$(CrossgenCommandline)"
Expand Down
2 changes: 0 additions & 2 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildASelfContainedApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public void It_builds_a_runnable_output()
});

Command.Create(selfContainedExecutableFullPath, new string[] { })
.EnsureExecutable()
.CaptureStdOut()
.Execute()
.Should()
Expand Down Expand Up @@ -123,7 +122,6 @@ public void It_succeeds_when_RuntimeIdentifier_and_PlatformTarget_mismatch_but_P
string selfContainedExecutableFullPath = Path.Combine(outputDirectory.FullName, selfContainedExecutable);

Command.Create(selfContainedExecutableFullPath, new string[] { })
.EnsureExecutable()
.CaptureStdOut()
.Execute()
.Should()
Expand Down
1 change: 0 additions & 1 deletion test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAnAppWithLibrariesAndRid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public void It_builds_a_RID_specific_runnable_output()
string selfContainedExecutableFullPath = Path.Combine(outputDirectory.FullName, selfContainedExecutable);

Command.Create(selfContainedExecutableFullPath, new string[] { })
.EnsureExecutable()
.CaptureStdOut()
.CaptureStdErr()
.Execute()
Expand Down
3 changes: 1 addition & 2 deletions test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ public void It_publishes_self_contained_apps_to_the_publish_folder_and_the_app_s
});

Command.Create(selfContainedExecutableFullPath, new string[] { })
.EnsureExecutable()
.CaptureStdOut()
.Execute()
.Should()
Expand Down Expand Up @@ -446,4 +445,4 @@ public void A_deployment_project_can_reference_the_hello_world_project()
.Pass();
}
}
}
}
1 change: 0 additions & 1 deletion test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAppWithLibrariesAndRid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ public void It_publishes_a_self_contained_runnable_output()
});

Command.Create(Path.Combine(publishDirectory.FullName, selfContainedExecutable), new string[] { })
.EnsureExecutable()
.CaptureStdOut()
.Execute()
.Should().Pass()
Expand Down
29 changes: 0 additions & 29 deletions test/Microsoft.NET.TestFramework/CommandExtensions.cs
View file
Open in desktop

This file was deleted.