Use shared compiler in CoreGenerateSatelliteAssemblies #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CoreGenerateSatelliteAssemblies` target uses the `Csc` task to create satellite assemblies. We can greatly speed up the creation of these assemblies by telling `Csc` to use the shared compiler server if it is available, rather than spinning up a new copy of csc.exe for every satellite.
|
For an example of the speed up, when using XliffTasks in the dotnet/roslyn repo without this change the build takes ten minutes. With this change it takes two and a half minutes. |
|
Cool. Until your recent msbuild change, this code could only be used on core. And there was no compiler server on core until just recently either. But neither are true now and this will be a huge win for core (and not just when opting in to use core generate on non-core as you're doing for roslyn now). Great timing! :) |
nguerrera
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CoreGenerateSatelliteAssembliestarget uses theCsctask tocreate satellite assemblies. We can greatly speed up the creation of
these assemblies by telling
Cscto use the shared compiler server ifit is available, rather than spinning up a new copy of csc.exe for every
satellite.