Merging dev/release/2.0 into release/2.0.0 #1776
Conversation
…t vs binary and which must have crlf (sln) vs lf (sh)
…ts in the test output folder
Moving to the repo toolset.
|
VSO builds are green, and publishing successfully, so we should be good to plumb this through to all the branches. CI will continue failing due to the netci.groovy changes which have to be checked in before they will work. |
tannergooding
requested review from
nguerrera,
dsplaisted,
livarcocc,
wli3 and
johnbeisner
| @@ -1,21 +0,0 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
I think my comment about these still being useful was lost in the original PR. Can we please fix up the paths and retain these?
There was a problem hiding this comment.
Added a -dogfood option and an explicit build\dogfood.bat script
| @@ -0,0 +1,3 @@ | |||
| @echo off | |||
| powershell -NoLogo -NoProfile -ExecutionPolicy ByPass -NoExit %~dp0Build.ps1 -dogfood %* | |||
| exit /b %ErrorLevel% | |||
There was a problem hiding this comment.
Will I actually get those environment variables set up for me if I do dogfood.cmd?
There was a problem hiding this comment.
Seems like they'd be trapped in the powershell process
There was a problem hiding this comment.
-NoExit preserves the powershell context when the script finishes executing
| export DOTNET_MSBUILD_SDK_RESOLVER_SDKS_DIR="$MSBuildSDKsPath" | ||
| export NETCoreSdkBundledVersionsProps="$DotNetRoot/sdk/$DotNetCliVersion/Microsoft.NETCoreSdk.BundledVersions.props" | ||
| export CustomAfterMicrosoftCommonTargets="$MSBuildSDKsPath/Microsoft.NET.Build.Extensions/msbuildExtensions-ver/Microsoft.Common.Targets/ImportAfter/Microsoft.NET.Build.Extensions.targets" | ||
| export MicrosoftNETBuildExtensionsTargets="$CustomAfterMicrosoftCommonTargets" |
There was a problem hiding this comment.
I want dotnet that was downloaded on my PATH too in this env.
There was a problem hiding this comment.
Its added to the path already down below
…201.3 (#1776) [main] Update dependencies from dotnet/roslyn
FYI. @dotnet/dotnet-cli