Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up package asset resolution #1857

Merged
merged 7 commits into from
Jan 25, 2018
Merged

Speed up package asset resolution #1857

merged 7 commits into from
Jan 25, 2018

Commits on Jan 25, 2018

  1. Remove unused generalization of dependency diagnostics

    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    8076b8a View commit details
    Browse the repository at this point in the history

  2. Remove bizarre target returns 

    Example: `Returns="_ActiveTFMFileDependencies"`

This returns the string `"_ActiveTFMFileDependencies"` not
`@(_ActiveTFMFileDependencies)".

Clearly these targets aren't actually run for their return values.

The useless values are cluttering the binlog and confusing me.
    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    b7b15e1 View commit details
    Browse the repository at this point in the history

  3. Raise only package assets that are used to build 

    The new task (ResolvePackageAssets) unlike the old ResolvePackageDependencies,
only raises items that that will actually be consumed by the build. The new
items are also much easier to consume in targets and do not require "joins"
to resolve paths, querying via WithMetadataValue, etc.
    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    0f958a9 View commit details
    Browse the repository at this point in the history

  4. Move validation for .NET Core RID in-box 

    Previously, Microsoft.NETCore.App package would do this in a custom
target with the PackageDependency items that we no longer raise by
default.

Also, use repo-toolset to generate designer code for resx during build.
There was a  project system bug preventing it from getting generated in VS.
    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    07f3285 View commit details
    Browse the repository at this point in the history

  5. Share helper code between old and new package-resolution tasks

    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    389d190 View commit details
    Browse the repository at this point in the history

  6. Add end-to-end analyzer resolution test

    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    af9be11 View commit details
    Browse the repository at this point in the history

  7. Add preprocessed content file end-to-end test

    @nguerrera
    nguerrera committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    430e180 View commit details
    Browse the repository at this point in the history