Updating SignToolData to include the produced nuget packages

[tannergooding]

No description provided.

[tannergooding]

FYI. @livarcocc

[livarcocc]

Could we just cherry-pick the commit? All these merge commits are annoying.

[tannergooding]

The merge commits will get created eventually (from the auto-merge bot).

[nguerrera]

I'm surprised that most of these are in our nupkg. They are supposed to be pulled in separately by the CLI from the corefx support package.

[tannergooding]

I believe most of them are in the tools directories.

[tannergooding]

(for netcoreapp)

[nguerrera]

Most of them are from Microsoft.NET.Build.Extensions\msbuildExtensions\Microsoft\Microsoft.NET.Build.Extensions, but those are excluded from the CLI ingestion here: https://github.com/dotnet/cli/blob/5c35438cfe1ac17fd4c748b8be6c2818d1238807/build/MSBuildExtensions.targets#L10-L17

We could (and probably should) exclude them from the .nupkg and not need to update these exclusions when the corefx support package changes.

[nguerrera]

tools\netcoreapp2.0 has nothing but our assembly + satellites. Some of these are from tools/net46 and necessary, but not all of them.

[tannergooding]

Fair enough, but that looks like it should be a separate work item, since this has been like this since before the infrastructure switch.

[nguerrera]

Agreed. I filed #1865

[livarcocc]

But 5 of them?

[tannergooding]

Yes. 1 is created for each merge.

There is one merge locally (dotnet/release/2.0.0 into tagoo/release/2.1)
And one more when the PR is merged (tagoo/release/2.1 into dotnet/release/2.1)
Then one more for the next local merge (dotnet/release/2.1 into tagoo/master)
And one more when that PR is merged (tagoo/master into dotnet/master).

There are some ways to remove some of the merges and create a more "linear" history (such as telling GitHub to rebase and merge or squash and merge), but those end up losing some information and can potentially make other actions more difficult (the only downside is the additional, sometimes empty, merge commits bringing both branches of the tree together).