-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert NuGet Build 4.7.0-preview1-4839 into sdk #1867
Conversation
Failing on Windows due to SkipNonexistentTargets, looks like Pack failed to detect full MsBuild. NuGet.Build.Tasks.Pack.targets(276,7): error MSB4064: The "SkipNonexistentTargets" parameter is not supported by the "Msbuild" task. D:\j\workspace\debug_windows---14cea53e\artifacts\Debug\bin\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(276,7): error MSB4064: The "SkipNonexistentTargets" parameter is not supported by the "Msbuild" task. Verify the parameter exists on the task, and it is a settable public instance property. [D:\j\workspace\debug_windows---14cea53e\artifacts\Debug\tmp\Nuget_referen---3B967D0F\D_netstandard1_0\D_netstandard1_0.csproj] |
On core msbuild, it passes all tests but failed on pack SDK itself. |
@rohit21agrawal could you have a look at it? |
core msbuild hit IsPackable = false. It is a new added error. Need to dig what cause that |
we added a new error that is thrown when you try to pack a project which has IsPackable = false set on it. |
@rohit21agrawal i think what we did is run /t:pack on the whole SLN. And we set all test project to be IsPackable=false to exclude. What is the recommend practice? |
|
you can have a top level target like "PackProject" which is imported by all projects but only executes if IsPackabe = true. in this target you can invoke pack on the project |
there is another build on nuget, but i want to keep running test on full msbuild |
fullframework failed on pack step, not msbuild problem anymore |
* Join macro * Make default format for the GUID macro overridable Fixes dotnet#1737 * Add links to the different template content repos in the readme * Convert repo list to bullets * Adding netstandard2.1 to the list of TFMs for 3.0 * Releases the original source location mount point * Change Build pool for internal builds (dotnet#1823) * Removing the SourceLink packages since it is provided by Arcade * Lowercase the content include path in the template pack csproj files * Add gitignore template * Update azure-pipelines.yml * Update web.config item template This updates the web.config item template to align with what `dotnet publish` produces when publishing * Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config Co-Authored-By: Justin Kotalik <jukotali@microsoft.com> * Merge master into stabilize (dotnet#1905) * Update dependencies from https://github.com/dotnet/arcade build 20190418.7 (dotnet#1867) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7 * Update dependencies from https://github.com/dotnet/arcade build 20190422.2 (dotnet#1870) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2 * Update dependencies from https://github.com/dotnet/arcade build 20190423.2 (dotnet#1871) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2 * Update dependencies from https://github.com/dotnet/arcade build 20190424.9 (dotnet#1873) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19224.9 * Update dependencies from https://github.com/dotnet/arcade build 20190425.5 (dotnet#1874) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5 * Update dependencies from https://github.com/dotnet/arcade build 20190426.3 (dotnet#1875) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19226.3 * Update dependencies from https://github.com/dotnet/arcade build 20190429.8 (dotnet#1876) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19229.8 * Update dependencies from https://github.com/dotnet/arcade build 20190430.6 (dotnet#1877) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6 * [master] Update dependencies from dotnet/arcade (dotnet#1879) * Update dependencies from https://github.com/dotnet/arcade build 20190501.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6 * Update dependencies from https://github.com/dotnet/arcade build 20190502.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2 * Update dependencies from https://github.com/dotnet/arcade build 20190503.8 (dotnet#1881) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8 * Update dependencies from https://github.com/dotnet/arcade build 20190504.1 (dotnet#1882) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1 * Update dependencies from https://github.com/dotnet/arcade build 20190505.2 (dotnet#1883) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2 * Update dependencies from https://github.com/dotnet/arcade build 20190506.12 (dotnet#1886) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12 * [master] Update dependencies from dotnet/arcade (dotnet#1888) * Update dependencies from https://github.com/dotnet/arcade build 20190507.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7 * Update dependencies from https://github.com/dotnet/arcade build 20190508.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5 * Update dependencies from https://github.com/dotnet/arcade build 20190509.9 (dotnet#1889) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9 * Update dependencies from https://github.com/dotnet/arcade build 20190510.2 (dotnet#1890) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2 * Update dependencies from https://github.com/dotnet/arcade build 20190511.1 (dotnet#1891) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1 * Update dependencies from https://github.com/dotnet/arcade build 20190512.1 (dotnet#1892) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1 * Update dependencies from https://github.com/dotnet/arcade build 20190513.3 (dotnet#1893) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3 * [master] Update dependencies from dotnet/arcade (dotnet#1895) * Update dependencies from https://github.com/dotnet/arcade build 20190514.13 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13 * Update dependencies from https://github.com/dotnet/arcade build 20190516.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2 * Update dependencies from https://github.com/dotnet/arcade build 20190516.4 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.4 * Update dependencies from https://github.com/dotnet/arcade build 20190517.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7 * Update dependencies from https://github.com/dotnet/arcade build 20190518.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2 * Update dependencies from https://github.com/dotnet/arcade build 20190520.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1 * Update dependencies from https://github.com/dotnet/arcade build 20190520.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.2 * Updating the glob.json to include the 2.1.x version * Update dependencies from https://github.com/dotnet/arcade build 20190521.7 (dotnet#1897) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19271.7 * Update dependencies from https://github.com/dotnet/arcade build 20190522.13 (dotnet#1898) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13 * Update dependencies from https://github.com/dotnet/arcade build 20190523.11 (dotnet#1899) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11 * Update dependencies from https://github.com/dotnet/arcade build 20190524.6 (dotnet#1901) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19274.6 * Update dependencies from https://github.com/dotnet/arcade build 20190528.1 (dotnet#1903) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19278.1 * Merging stabilize into master (dotnet#1904) * Join macro * Make default format for the GUID macro overridable Fixes dotnet#1737 * Add links to the different template content repos in the readme * Convert repo list to bullets * Adding netstandard2.1 to the list of TFMs for 3.0 * Releases the original source location mount point * Change Build pool for internal builds (dotnet#1823) * Removing the SourceLink packages since it is provided by Arcade * Lowercase the content include path in the template pack csproj files * Add gitignore template * Update azure-pipelines.yml * Update web.config item template This updates the web.config item template to align with what `dotnet publish` produces when publishing * Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config Co-Authored-By: Justin Kotalik <jukotali@microsoft.com> * Update --langVersion option's description * Removing Microsoft.Extensions.CommandLineUtils references from the repo
* Join macro * Make default format for the GUID macro overridable Fixes dotnet#1737 * Add links to the different template content repos in the readme * Convert repo list to bullets * Adding netstandard2.1 to the list of TFMs for 3.0 * Releases the original source location mount point * Change Build pool for internal builds (dotnet#1823) * Removing the SourceLink packages since it is provided by Arcade * Lowercase the content include path in the template pack csproj files * Add gitignore template * Update azure-pipelines.yml * Update web.config item template This updates the web.config item template to align with what `dotnet publish` produces when publishing * Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config Co-Authored-By: Justin Kotalik <jukotali@microsoft.com> * Merge master into stabilize (dotnet#1905) * Update dependencies from https://github.com/dotnet/arcade build 20190418.7 (dotnet#1867) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7 * Update dependencies from https://github.com/dotnet/arcade build 20190422.2 (dotnet#1870) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2 * Update dependencies from https://github.com/dotnet/arcade build 20190423.2 (dotnet#1871) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2 * Update dependencies from https://github.com/dotnet/arcade build 20190424.9 (dotnet#1873) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19224.9 * Update dependencies from https://github.com/dotnet/arcade build 20190425.5 (dotnet#1874) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5 * Update dependencies from https://github.com/dotnet/arcade build 20190426.3 (dotnet#1875) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19226.3 * Update dependencies from https://github.com/dotnet/arcade build 20190429.8 (dotnet#1876) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19229.8 * Update dependencies from https://github.com/dotnet/arcade build 20190430.6 (dotnet#1877) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6 * [master] Update dependencies from dotnet/arcade (dotnet#1879) * Update dependencies from https://github.com/dotnet/arcade build 20190501.6 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6 * Update dependencies from https://github.com/dotnet/arcade build 20190502.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2 * Update dependencies from https://github.com/dotnet/arcade build 20190503.8 (dotnet#1881) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8 * Update dependencies from https://github.com/dotnet/arcade build 20190504.1 (dotnet#1882) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1 * Update dependencies from https://github.com/dotnet/arcade build 20190505.2 (dotnet#1883) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2 * Update dependencies from https://github.com/dotnet/arcade build 20190506.12 (dotnet#1886) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12 * [master] Update dependencies from dotnet/arcade (dotnet#1888) * Update dependencies from https://github.com/dotnet/arcade build 20190507.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7 * Update dependencies from https://github.com/dotnet/arcade build 20190508.5 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5 * Update dependencies from https://github.com/dotnet/arcade build 20190509.9 (dotnet#1889) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9 * Update dependencies from https://github.com/dotnet/arcade build 20190510.2 (dotnet#1890) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2 * Update dependencies from https://github.com/dotnet/arcade build 20190511.1 (dotnet#1891) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1 * Update dependencies from https://github.com/dotnet/arcade build 20190512.1 (dotnet#1892) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1 * Update dependencies from https://github.com/dotnet/arcade build 20190513.3 (dotnet#1893) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3 * [master] Update dependencies from dotnet/arcade (dotnet#1895) * Update dependencies from https://github.com/dotnet/arcade build 20190514.13 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13 * Update dependencies from https://github.com/dotnet/arcade build 20190516.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2 * Update dependencies from https://github.com/dotnet/arcade build 20190516.4 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.4 * Update dependencies from https://github.com/dotnet/arcade build 20190517.7 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7 * Update dependencies from https://github.com/dotnet/arcade build 20190518.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2 * Update dependencies from https://github.com/dotnet/arcade build 20190520.1 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1 * Update dependencies from https://github.com/dotnet/arcade build 20190520.2 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.2 * Updating the glob.json to include the 2.1.x version * Update dependencies from https://github.com/dotnet/arcade build 20190521.7 (dotnet#1897) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19271.7 * Update dependencies from https://github.com/dotnet/arcade build 20190522.13 (dotnet#1898) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13 * Update dependencies from https://github.com/dotnet/arcade build 20190523.11 (dotnet#1899) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11 * Update dependencies from https://github.com/dotnet/arcade build 20190524.6 (dotnet#1901) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19274.6 * Update dependencies from https://github.com/dotnet/arcade build 20190528.1 (dotnet#1903) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19278.1 * Merging stabilize into master (dotnet#1904) * Join macro * Make default format for the GUID macro overridable Fixes dotnet#1737 * Add links to the different template content repos in the readme * Convert repo list to bullets * Adding netstandard2.1 to the list of TFMs for 3.0 * Releases the original source location mount point * Change Build pool for internal builds (dotnet#1823) * Removing the SourceLink packages since it is provided by Arcade * Lowercase the content include path in the template pack csproj files * Add gitignore template * Update azure-pipelines.yml * Update web.config item template This updates the web.config item template to align with what `dotnet publish` produces when publishing * Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config Co-Authored-By: Justin Kotalik <jukotali@microsoft.com> * Update --langVersion option's description * Removing Microsoft.Extensions.CommandLineUtils references from the repo
…0.1xx Merge release/6.x to release/7.0.1xx
Insert NuGet Build 4.7.0-preview1-4839 into sdk master branch