Run restore and create build log by default from build.cmd #1943
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
approved these changes
Feb 9, 2018
|
Merge it |
I would wait until @jaredpar has confirmed it won't interfere with repo api. |
|
As long as it can be controlled it won't interfere. Note: do we have a place where all the command line arguments to repo-tools are documented (including defaults)? |
|
We should have consistent behavior in build.sh |
dsplaisted
force-pushed
the
build-script-defaults
branch
from
aa25ff0
to
424efdb
Compare
@nguerrera I've updated the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisiting #1758.
This time the defaults are in the
build.cmdinstead ofbuild\build.ps1, so it shouldn't affect the "Repo API".I looked at the defaults in
build.cmdfor the different repos using RepoToolset, and there wasn't much consistency. Some of the restore by default, and some don't. At least one logs by default. I don't think any of them run tests by default, so I'm not enabling that in this PR.@nguerrera @tannergooding @tmat @jaredpar