Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When converting CompileOptions, exclude empty entries when spliting DefineConstants. #1952

Merged
merged 2 commits into from
Feb 12, 2018
Merged

When converting CompileOptions, exclude empty entries when spliting DefineConstants. #1952

merged 2 commits into from
Feb 12, 2018

Conversation

livarcocc
Copy link
Contributor

Fixes #1628

@livarcocc livarcocc added this to the 2.1.3xx milestone Feb 12, 2018
@livarcocc livarcocc requested review from eerhardt and a team February 12, 2018 17:40
@livarcocc livarcocc merged commit 83ba345 into dotnet:master Feb 12, 2018
@livarcocc livarcocc deleted the remove_empty_compilation_options branch February 12, 2018 23:53
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
@dotnet-maestro
[main] Update dependencies from dotnet/arcade (#1952)
7288c72 
[main] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguerrera nguerrera nguerrera approved these changes

@eerhardt eerhardt eerhardt approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.3xx
Development

Successfully merging this pull request may close these issues.
4 participants
@livarcocc @nguerrera @eerhardt @tannergooding