Fix flaky parser tests #19571
Merged
Fix flaky parser tests #19571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
approved these changes
Aug 6, 2021
|
We saw this yaml file failure earlier today and then it magically worked when we reran another SDK build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parser tests that check what arguments are being passed to MSBuild are failing because an extra parameter along the lines of
-distributedlogger:Microsoft.DotNet....is being added occasionally. This argument comes from telemetry logic and can be removed by setting the current session id to null in tests: https://github.com/dotnet/sdk/blob/main/src/Cli/dotnet/commands/dotnet-msbuild/MSBuildForwardingApp.cs#L26Fixes #19544