Port fix for mismatched NuGet versions to release/2.1.1xx. #2016
Conversation
This commit ports the fix for the mismatched NuGet version numbers used by the SDK. See dotnet#1831 for the change into master.
|
Do not merge without approval. |
|
Customer scenario Perf. Using VS 15.6 can result in extra copies of NuGet DLLs being loaded SxS. Furthermore, this change was required to produce a source build because there cannot be more than version of NuGet. Bugs this fixes: Workarounds, if any Accept the perf hit. Source build can apply a patch, but this keeps a discrepancy betweeen source and non-source-builds and adds debt. By putting this low risk fix into the next servicing release, we eliminate that debt sooner. Risk Low Performance impact Can reduce number of assemblies loaded in devenv.exe. Is this a regression from a previous update? Yes. Root cause analysis: Prior to the move to repo toolset, we had only one version of nuget in DependencyVersion.props. This was split into 1 version per package and then merged incorrectly between branches causing the nuget version to be downgraded from 15.5 to 15.4 instead of upgraded to 15.6 equivalent. Source build needs to be continuously updated (work is in progress on this). Version.props should never duplicate versions, but instead reference something that needs to have the same version by name. This is what the patch here does. How was the bug found? Preparing source build. |
|
@MattGertz we need this fix. I am approving and will chat with you tomorrow. Will take out if you disagree. But I want to cook up the VS insertion build tonight. |
|
No disagreement. |
* Update dependencies from https://github.com/dotnet/source-build-externals build 20231030.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23530.1 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231106.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23556.2 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231116.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23566.1 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231120.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23570.2 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231127.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23577.2 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231208.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23608.1 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231211.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23611.2 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231211.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23611.2 * Update dependencies from https://github.com/dotnet/source-build-externals build 20231228.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 9.0.0-alpha.1.23518.2 -> To Version 9.0.0-alpha.1.23628.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This commit ports the fix for the mismatched NuGet version numbers used by the
SDK.
See #1831 for the change into master.