Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global.json #20212

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Update global.json #20212

merged 6 commits into from
Aug 30, 2021

Conversation

wli3
Copy link

@wli3 wli3 commented Aug 26, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@wli3
Copy link
Author

wli3 commented Aug 26, 2021

WPF fix is still not flowed in

@wli3
Copy link
Author

wli3 commented Aug 26, 2021

@mmitche looking at https://github.com/dotnet/installer/pulls?page=1&q=is%3Apr+is%3Aclosed there is no main PR from dotnet/sdk to dotnet/installer. Could you check the subscription?

@marcpopMSFT
Copy link
Member

@mmitche
Copy link
Member

mmitche commented Aug 26, 2021

@mmitche
Copy link
Member

mmitche commented Aug 27, 2021

@wli3 Failure was because I hit squash on that massive dependency update PR and created a giant commit message. WiX is not happy with such things. Note that normal dependency update auto-merges will avoid this by altering the commit message on merge. The latest build passed!

@wli3
Copy link
Author

wli3 commented Aug 27, 2021

looks like workloads does not roll forward

@sfoslund
Copy link
Member

looks like workloads does not roll forward

It looks like the included manifests file is present in this updated stage 0 version but I can repro these errors when there aren't any manifests to fall back on, that is, when I clean my repo before building or just delete the 6.0.100 manifests dir that I happened to have installed from building a different branch.

I think to get this feature to work we have to have an additional SDK version installed to the stage 0 dir that has manifests to fall back on, otherwise it fails on a clean install.

@wli3
Copy link
Author

wli3 commented Aug 27, 2021

Looks into it with Sarah offline. A lot of things wrong here #20268.

@wli3 wli3 merged commit deebf2f into main Aug 30, 2021
@sfoslund sfoslund deleted the wli3-patch-2 branch August 30, 2021 17:45
@wli3
Copy link
Author

wli3 commented Aug 30, 2021

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants