-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global.json #20212
Update global.json #20212
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
WPF fix is still not flowed in |
@mmitche looking at https://github.com/dotnet/installer/pulls?page=1&q=is%3Apr+is%3Aclosed there is no main PR from dotnet/sdk to dotnet/installer. Could you check the subscription? |
@wli3 there appear to be some main flows going: https://github.com/dotnet/installer/pulls?q=is%3Apr+base%3Amain+author%3Aapp%2Fdotnet-maestro+is%3Aopen |
Yes, and then the official build failed :( https://dev.azure.com/dnceng/internal/_build/results?buildId=1321610&view=logs&j=09811346-8274-5b72-2d96-1dd38f87c84b&t=1076a253-d673-5a07-955b-d64ed38c1de3 |
@wli3 Failure was because I hit squash on that massive dependency update PR and created a giant commit message. WiX is not happy with such things. Note that normal dependency update auto-merges will avoid this by altering the commit message on merge. The latest build passed! |
looks like workloads does not roll forward |
It looks like the included manifests file is present in this updated stage 0 version but I can repro these errors when there aren't any manifests to fall back on, that is, when I clean my repo before building or just delete the 6.0.100 manifests dir that I happened to have installed from building a different branch. I think to get this feature to work we have to have an additional SDK version installed to the stage 0 dir that has manifests to fall back on, otherwise it fails on a clean install. |
Looks into it with Sarah offline. A lot of things wrong here #20268. |
awesome! |
No description provided.