Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bash shebang for scripts to run under FreeBSD #21361

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fix Bash shebang for scripts to run under FreeBSD #21361

merged 1 commit into from
Oct 30, 2021

Conversation

sec
Copy link
Contributor

@sec sec commented Sep 24, 2021

Not on all OS'es bash is placed under /bin (ex. FreeBSD). This small PR fixes those issues when running those scripts on such systems.

@dnfadmin
Copy link

dnfadmin commented Sep 24, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@sec sec mentioned this pull request Sep 24, 2021
Open
josteink
josteink approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@josteink josteink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks consistent with similar fixes we've submitted for FreeBSD in the past.

@sec sec changed the title Fix Bash shebang for scripts Fix Bash shebang for scripts to run under FreeBSD Sep 24, 2021
@josteink
Copy link
Member

Knock knock!

Any reason this isn’t reviewed and merged yet? It’s a very sinple patch.

Cc: @jkotas @dleeapho

@jkotas jkotas merged commit 1814193 into dotnet:main Oct 30, 2021
@josteink
Copy link
Member

Thanks!

@sec sec deleted the fix-bash-shebang branch November 2, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josteink josteink josteink approved these changes

@dleeapho dleeapho Awaiting requested review from dleeapho

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sec @dnfadmin @josteink @jkotas