WIP Expanding test: 'GivenThatWeWantToRestoreProjectsUsingNuGetConfigProperties' #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
Looks good.
(One small nit for the future: it is better to describe something about what the change achieves in the PR title. Fix #NNNN can be added in parens to title or just in the description. This helps with email notifications for people to decide if a change is relevant to them, it also helps browse the list of PRs, etc. etc.)
johnbeisner
changed the title
johnbeisner
changed the title
|
closing - jbeisner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #1327