Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticWebAssets] Process endpoint definitions in parallel #43736

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Sep 26, 2024

  • Do not pass ExistingEndpoints to the DefineStaticWebAssetEndpoints calls for build assets (they aren't needed).
  • Avoid deserializing the full endpoint (only the asset file and the route are used to avoid adding duplicate endpoints).
  • Process endpoints in parallel

Around ~1s saving

Before

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.29

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.26

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.08

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.22

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.23

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.29

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.20

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.21

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.22

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.24

After

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.13

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.26

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.19

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.12

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.16

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.26

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.11

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.15

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:07.27

Build succeeded.
    0 Warning(s)
    0 Error(s)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Sep 26, 2024
@javiercn javiercn force-pushed the javiercn/parallel-define-static-webasset-endpoints branch 2 times, most recently from bb93e2a to 9389124 Compare October 7, 2024 17:18
@javiercn javiercn marked this pull request as ready for review October 7, 2024 17:38
@javiercn javiercn force-pushed the javiercn/parallel-define-static-webasset-endpoints branch from 9389124 to 32f444d Compare October 8, 2024 12:02
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small suggestions.

@javiercn javiercn force-pushed the javiercn/parallel-define-static-webasset-endpoints branch from 32f444d to c1f409c Compare October 9, 2024 12:25
@javiercn javiercn force-pushed the javiercn/parallel-define-static-webasset-endpoints branch from c1f409c to e007c41 Compare October 11, 2024 08:58
@javiercn javiercn merged commit 0a8079e into main Oct 11, 2024
36 checks passed
@javiercn javiercn deleted the javiercn/parallel-define-static-webasset-endpoints branch October 11, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants