[main] Update dependencies from dotnet/msbuild

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

• Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
• Build: 20241014.4
• Date Produced: October 14, 2024 10:35:55 AM UTC
• Commit: 8317db7f6c2a121d57b664b84b5c2f5cec125adf
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.msbuild: from 17.13.0-preview-24509-17 to 17.13.0-preview-24514-04
  • Microsoft.Build: from 17.13.0-preview-24509-17 to 17.13.0-preview-24514-04
  • Microsoft.Build.Localization: from 17.13.0-preview-24509-17 to 17.13.0-preview-24514-04

[nagilson]

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.Publish_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest

A blazor test is failing. Rerunning.

[nagilson]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[nagilson]

Same as #44018

[nagilson]

@dotnet/aspnet-blazor-eng Expected collection to be empty because the generated manifest should match the expected baseline. This blazor wasm test appears to be broken. I dont think this is a problem with MSBuild. May you PTAL?

[javiercn]

Taking a look

[javiercn]

@wtgodbe for some reason it seems that the VMR is trying to run node.js code.

Has anything changed here recently?

This is the command being passed on

repo-projects\Directory.Build.targets(459,5): error MSB3073: The command "D:\a\_work\1\vmr\src\aspnetcore\eng\build.cmd -restore -all -pack -publish -NativeToolsOnMachine -ci -configuration Release -bl /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=D:\a\_work\1\vmr\artifacts\obj\aspnetcore\NuGet.config /p:SourceBuiltAssetsDir=D:\a\_work\1\vmr\artifacts\assets\Release\ /p:SourceBuiltAssetManifestsDir=D:\a\_work\1\vmr\artifacts\obj\AssetManifests\aspnetcore\ -arch x64 /p:TargetRuntimeIdentifier=win-x64 /p:SourceBuiltShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\Shipping\aspnetcore\ /p:SourceBuiltNonShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\NonShipping\aspnetcore > D:\a\_work\1\vmr\artifacts\log\Release\aspnetcore\aspnetcore.log 2>&1" exited with code 1.

[wtgodbe]

We haven't changed anything recently (3 months) as far as I can tell - we should be globally disabling the node build during SourceBuild (that is, when DotNetBuildSourceOnly is true): https://github.com/dotnet/aspnetcore/blob/049814ca468cad1ea1e29412e0aa3eea182a63c1/eng/Common.props#L12-L13

I don't see that prop being passed on the command line, maybe it's set during source-build but not the VMR build? CC @MichaelSimons @mthalman do you know?

[mthalman]

I don't see any aspnetcore errors right now in the build results. I do see an msbuild error:

/vmr/src/msbuild/src/Build/Evaluation/Profiler/EvaluationLocationPrettyPrinterBase.cs(78,24): error CS0121: (NETCORE_ENGINEERING_TELEMETRY=Build) The call is ambiguous between the following methods or properties: 'string.Join(string?, params ReadOnlySpan<object?>)' and 'string.Join(string?, params ReadOnlySpan<string?>)'