Added OSX and Ubuntu 16.04 to the pr job builders. #894

333fred · 2017-02-21T21:15:03Z

This adds OSX to the list of PR jobs so that we verify all commits on it.

333fred · 2017-02-21T21:15:16Z

nguerrera · 2017-02-25T03:07:57Z

Retarget to master after #917 goes in

* dotnet/master: (21 commits) fixing iteration of publish filter list Fix test expectation to match project change coming from master add "ubuntu.16.04-x64" as valid RID for RID tests Filter out System files during caching step Remove Default FX_Version, as we let it to default to CLI in usage Build with VS 15 dev tools Use Dev15 CI machines for Windows builds Don't set environment variables for VS SDK during CI runs Try fixing groovy script Set VS Install location environment variables in netci.groovy Creating an Intermediate directory for cache to work in Refactoring Crossgen and enabling parallel execution of Crossgen Fix test for new runtimeconfig.json property. Fix Global user path Fixed the download scripts to consume cli rel/1.0.0 branch Integration test for publish filter profile Adding a FilterProfile option to filter out the closure of specified list of packages Integration Test for ComposeCache Compose cache Update NuGet to include new TFMs for .NET Core 2.0. ...

333fred · 2017-02-27T18:08:37Z

@dotnet-bot test ci please

dsplaisted · 2017-03-06T22:26:37Z

Are we waiting on anything to merge this? @333fred @nguerrera

333fred · 2017-03-06T22:28:02Z

It still doesn't work. See the offline mail thread.

nguerrera

Preventing merge based on the fact that this isn't working (see above)

333fred · 2017-03-07T00:34:55Z

@dotnet-bot test ci please

eerhardt · 2017-03-09T15:06:37Z

What's the status of this? We've introduced more "OSX" specific failures in the meantime: See #965

333fred · 2017-03-09T18:12:11Z

@dotnet-bot test ci please

333fred · 2017-03-09T18:17:35Z

Setting HOME appears to have made the build successful. @nguerrera, can you approve?

333fred · 2017-03-09T18:22:20Z

Test failures on OSX, appear to be the same ones in #965.

nguerrera · 2017-03-09T18:37:40Z

build.sh

@@ -35,7 +35,7 @@ while [[ $# > 0 ]]; do
            args=( "${args[@]/$1}" )
            args=( "${args[@]/$2}" )
            shift
-            ;;        
+            ;;


I keep seeing unrelated whitespace cleanup. Is your editor configured to do that? It's not code review friendly.

Yes, my editor trims whitespace. Which works fine when I'm creating a file, but less fine when I'm not.

eerhardt · 2017-03-09T18:39:17Z

Test failures on OSX, appear to be the same ones in #965.

Working on fixing them now.

nguerrera · 2017-03-09T18:39:31Z

build.sh

+if [ -z "$HOME" ]; then
+    export HOME="$REPOROOT/.home"
+
+    [ ! -d "$HOME" ] || rm -Rf $HOME


This line is terrifying. Do we really need to delete it? CI does a clean of the enlistment, right? And we don't put stuff in there.

I copied it from the CliCommandLineParser repo. @jonsequitur, was there a reasoning behind deleting everything?

I have an extremely strong feeling that CliCommandLineParser just copied it from

https://github.com/dotnet/cli/blob/master/build.sh#L19-L25

which came in over a year ago here:
dotnet/cli@34b0b68
with the commit message patch up some final missing CI build things

nguerrera · 2017-03-09T18:41:09Z

build.sh


 # Use a repo-local install directory (but not the artifacts directory because that gets cleaned a lot
 [ -z "$DOTNET_INSTALL_DIR" ] && export DOTNET_INSTALL_DIR=$REPOROOT/.dotnet_cli
 [ -d "$DOTNET_INSTALL_DIR" ] || mkdir -p $DOTNET_INSTALL_DIR

+# Some things depend on HOME and it may not be set. We should fix those things, but until then, we just patch a value in


This should say what things and link to bugs.

nguerrera · 2017-03-09T18:42:18Z

netci.groovy

@@ -10,7 +10,7 @@ def project = GithubProject
 def branch = GithubBranchName
 def isPR = true

-def osList = ['Windows_NT', 'Windows_NT_FullFramework', 'Ubuntu14.04']
+def osList = ['Windows_NT', 'Windows_NT_FullFramework', 'Ubuntu14.04', 'Ubuntu16.04', 'OSX']


Does this include 10.12?

Not sure, @mmitche? What OS is the OSX host?

See https://github.com/dotnet/corefx/pull/16562/files for how corefx explicitly includes 10.12

nguerrera · 2017-03-09T19:04:04Z

build.sh

@@ -68,7 +68,7 @@ export NUGET_HTTP_CACHE_PATH="$REPOROOT/packages"
 [ -z "$DOTNET_INSTALL_DIR" ] && export DOTNET_INSTALL_DIR=$REPOROOT/.dotnet_cli
 [ -d "$DOTNET_INSTALL_DIR" ] || mkdir -p $DOTNET_INSTALL_DIR

-# Some things depend on HOME and it may not be set. We should fix those things, but until then, we just patch a value in
+# NuGet depends on HOME and it may not be set. Until it's fixed, we just patch a value in


eerhardt · 2017-03-09T21:06:47Z

test ci please

eerhardt · 2017-03-09T21:19:07Z

~~@333fred - I'm getting errors on the OSX run with your latest changes:~~

~~https://ci.dot.net/job/dotnet_sdk/job/master/job/GenPRTest/job/release_osx10.12_prtest/1/console~~

13:09:16 Unhandled Exception: System.ArgumentNullException: Value cannot be null.
13:09:16 Parameter name: path1
13:09:16    at System.IO.Path.Combine(String path1, String path2, String path3)
13:09:16    at NuGet.Common.NuGetEnvironment.GetFolderPath(SpecialFolder folder)
13:09:16    at NuGet.Common.NuGetEnvironment.GetFolderPath(NuGetFolderPath folder)
13:09:16    at NuGet.Configuration.SettingsUtility.GetHttpCacheFolder()
13:09:16    at NuGet.Configuration.NuGetPathContext.Create(ISettings settings)
13:09:16    at Microsoft.DotNet.Configurer.NuGetCacheSentinel.get_NuGetCachePath()
13:09:16    at Microsoft.DotNet.Configurer.NuGetCacheSentinel.Exists()
13:09:16    at Microsoft.DotNet.Cli.Telemetry..ctor(INuGetCacheSentinel sentinel, String sessionId)
13:09:16    at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient)
13:09:16    at Microsoft.DotNet.Cli.Program.Main(String[] args)

~~are the NuGet env vars set up correctly?~~

IGNORE: I was running "master".

eerhardt · 2017-03-09T22:00:56Z

@333fred @nguerrera - OSX.10.12 now passes:

https://ci.dot.net/job/dotnet_sdk/job/master/job/GenPRTest/job/release_osx10.12_prtest/3/

I'll let you guys merge when ready.

dnfclas added the cla-already-signed label Feb 21, 2017

nguerrera approved these changes Feb 22, 2017

View reviewed changes

333fred changed the base branch from future to master February 27, 2017 17:46

Added osx to the pr job builders.

96ab6dc

333fred force-pushed the osx-build branch from fe560d6 to 96ab6dc Compare February 27, 2017 17:50

333fred added 2 commits February 27, 2017 10:04

Added Ubuntu 16.04 to pr builders

6900899

333fred changed the title ~~Added osx to the pr job builders.~~ Added OSX and Ubuntu 16.04 to the pr job builders. Feb 27, 2017

333fred added 2 commits February 27, 2017 10:44

Set NUGET_HTTP_CACHE_PATH

c914742

Set NUGET_HTTP_CACHE_PATH in subproject call

99c280c

nguerrera approved these changes Feb 27, 2017

View reviewed changes

livarcocc approved these changes Feb 27, 2017

View reviewed changes

nguerrera suggested changes Mar 6, 2017

View reviewed changes

Set HOME

7ae6498

nguerrera reviewed Mar 9, 2017

View reviewed changes

Use osx10.12 explicitly and update comment

4cf583f

nguerrera reviewed Mar 9, 2017

View reviewed changes

nguerrera approved these changes Mar 9, 2017

View reviewed changes

Merge branch 'master' into osx-build

e27c53f

333fred merged commit 8da0846 into dotnet:master Mar 9, 2017

333fred deleted the osx-build branch March 9, 2017 22:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added OSX and Ubuntu 16.04 to the pr job builders. #894

Added OSX and Ubuntu 16.04 to the pr job builders. #894

333fred commented Feb 21, 2017

333fred commented Feb 21, 2017

nguerrera commented Feb 25, 2017

333fred commented Feb 27, 2017

dsplaisted commented Mar 6, 2017

333fred commented Mar 6, 2017

nguerrera left a comment

333fred commented Mar 7, 2017

eerhardt commented Mar 9, 2017

333fred commented Mar 9, 2017

333fred commented Mar 9, 2017

333fred commented Mar 9, 2017

nguerrera Mar 9, 2017 •

edited

Loading

333fred Mar 9, 2017

eerhardt commented Mar 9, 2017

nguerrera Mar 9, 2017

333fred Mar 9, 2017

eerhardt Mar 9, 2017

nguerrera Mar 9, 2017

nguerrera Mar 9, 2017

333fred Mar 9, 2017

eerhardt Mar 9, 2017

nguerrera Mar 9, 2017

eerhardt commented Mar 9, 2017

eerhardt commented Mar 9, 2017 •

edited

Loading

eerhardt commented Mar 9, 2017

Added OSX and Ubuntu 16.04 to the pr job builders. #894

Added OSX and Ubuntu 16.04 to the pr job builders. #894

Conversation

333fred commented Feb 21, 2017

333fred commented Feb 21, 2017

nguerrera commented Feb 25, 2017

333fred commented Feb 27, 2017

dsplaisted commented Mar 6, 2017

333fred commented Mar 6, 2017

nguerrera left a comment

Choose a reason for hiding this comment

333fred commented Mar 7, 2017

eerhardt commented Mar 9, 2017

333fred commented Mar 9, 2017

333fred commented Mar 9, 2017

333fred commented Mar 9, 2017

nguerrera Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eerhardt commented Mar 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eerhardt commented Mar 9, 2017

eerhardt commented Mar 9, 2017 • edited Loading

eerhardt commented Mar 9, 2017

nguerrera Mar 9, 2017 •

edited

Loading

eerhardt commented Mar 9, 2017 •

edited

Loading