Bump version to v2.0 #999
Merged
Bump version to v2.0 #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livarcocc
approved these changes
Mar 16, 2017
eerhardt
reviewed
Mar 16, 2017
| @@ -28,7 +28,7 @@ | |||
| <!-- Reset $(BuildEpoch) whenever $(VersionPrefix) increments. We subtract this from YYYYMMDD portion of build | |||
| number below to obtain the fourth part of file version that must fit in 16 bits. We can produce builds | |||
| for seven years from every epoch reset. --> | |||
| <VersionPrefix Condition="'$(VersionPrefix)' == ''">1.1.0</VersionPrefix> | |||
| <VersionPrefix Condition="'$(VersionPrefix)' == ''">2.0.0</VersionPrefix> | |||
| <BuildEpoch>20170101</BuildEpoch> | |||
There was a problem hiding this comment.
Should this get reset, like the above comment indicates?
There was a problem hiding this comment.
Or I guess it is the same year, so no real reason to touch it.
There was a problem hiding this comment.
Maybe fix the comment then?
There was a problem hiding this comment.
It should, but we're so close enough in time to current epoch, it doesn't really matter. (But moving forward, do as I say, not as I do ;))
eerhardt
approved these changes
Mar 16, 2017
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
Updating the branding to Preview2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligning SDK version with CLI version, which allows some VS compat goop in Common.props to go away.
@dsplaisted @livarcocc @eerhardt